Emergency#0001 priority-request#61
Conversation
…0001 via Membership-priority request
SCDerox
left a comment
SCDerox
left a comment
There was a problem hiding this comment.
one typo, and two recommendations for clearer™️ code
| if (moduleConfig.remove === true) { | ||
| await member.roles.remove(member.roles.cache.filter(role => !role.managed)); | ||
| } |
There was a problem hiding this comment.
Could be even more simplified:
| if (moduleConfig.remove === true) { | |
| await member.roles.remove(member.roles.cache.filter(role => !role.managed)); | |
| } | |
| if (moduleConfig.remove) await member.roles.remove(member.roles.cache.filter(role => !role.managed)); |
|
As a oss-contributor, you do not need to care about Priority-Request, please do not feel forced to implement them. (You can always ask them for a small donation or something if they really need a feature). Only implementing stuff you like and only if you enjoy implementing it. |
Co-authored-by: Simon <sc.de@gmx.de>
Co-authored-by: Simon <sc.de@gmx.de>
SCDerox
left a comment
SCDerox
left a comment
There was a problem hiding this comment.
thx 4 fast fix, will merge it ^^
1st it is not a very big thing to make, 2nd it is something I can do between my copy-pasting for my current project :hAA: so no problem for this change |
2 participants
No description provided.