cmake improvements for distros #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CMake default is to enable both C and CXX, which leads to build failure if C++ compiler is not present in the build environment. Explicitly stating that we don't need C++ allows distributions that build their packages in controlled environment to get rid of extra g++ build dependency.
Different distributions have different standards about it, so let's add an option for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm maintaining HeadsetControl package for the distribution I use (ALT Sisyphus). While working on update to 2.5, I found that a couple of minor changes to
CMakeLists.txtwould make my job as a maintainer easier.First, as most of (binary) distros do, we are building our package in a controlled environment that does not have a C++ compiler by default. Specifying that HeadsetControl is C-only project avoids the necessity to install it there.
Second, we're installing udev rules to
/lib/udev/rules.d, which is not a symlink to/usr/lib/udev/rules.dor anything like that. So I added an option to specify where CMake should put the udev rules file.