Skip to content

Fix notification handling (edits, reactions)#233

Merged
7w1 merged 2 commits intoSableClient:devfrom
Just-Insane:fix/notification-handling
Mar 13, 2026
Merged

Fix notification handling (edits, reactions)#233
7w1 merged 2 commits intoSableClient:devfrom
Just-Insane:fix/notification-handling

Conversation

@Just-Insane
Copy link
Contributor

@Just-Insane Just-Insane commented Mar 12, 2026

  • Fix issues with badges for edits, reactions
  • Improve unread count calculations
  • Fix background notification edge cases

@Just-Insane Just-Insane requested a review from a team March 12, 2026 18:32
@Just-Insane Just-Insane changed the title Fix notification handling with null safety Fix notification handling (edits, reactions) Mar 12, 2026
- Update BackgroundNotifications.tsx to use single-argument isNotificationEvent
- Update roomToUnread.ts to use single-argument isNotificationEvent
- Auto-format files with prettier
- All TypeScript and ESLint checks passing
@7w1 7w1 merged commit 466442c into SableClient:dev Mar 13, 2026
6 checks passed
@Just-Insane Just-Insane deleted the fix/notification-handling branch March 13, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants