Skip to content

Add builtin_items data to whats_left.html #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 6, 2025
Merged

Add builtin_items data to whats_left.html #81

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b451253
Add builtin_items data to whats_left.html
fanninpm Nov 5, 2025
4178638
Rework logic to group items by the "builtin" key
fanninpm Nov 5, 2025
c621759
Rework script to address review comments
fanninpm Nov 6, 2025
5ac3b5b
Reflow space around conditional in list item
fanninpm Nov 6, 2025
e46a987
Give reason for early exit in shell script
fanninpm Nov 6, 2025
fae0be0
Replace paths relative to execution with paths relative to script
fanninpm Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rework logic to group items by the "builtin" key 
This obviates the need for the Prettier workaround.
  • Loading branch information
@fanninpm
fanninpm committed Nov 5, 2025
commit 417863874015d67808b0bd4eba8598754a4b7745
23 changes: 10 additions & 13 deletions _layouts/whats_left.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,18 +42,15 @@
</div>

<div class="section-title">What's left: Built-in Items</div>
{% assign previous_builtin = "" %}
{% comment %}<div><ol><!-- this makes prettier not crash -->{% endcomment %}
{% for item in site.data.whats_left.builtin_items %}
{% if item.builtin != previous_builtin %}
{% if previous_builtin != "" %}
</ol></div>
{% endif %}
<h4>{{ item.builtin }}</h4>
<div class="column-count-is-2"><ol>
{% endif %}
<li class="word-wrap-anywhere"><code>{{ item.name }}</code> {% if item.is_inherited %}{{ item.is_inherited }}{% endif %}</li>
{% assign previous_builtin = item.builtin %}
{% assign items_by_builtin = site.data.whats_left.builtin_items | group_by: "builtin" %}
{% for group in items_by_builtin %}
<h4>{{ group.name }}</h4>
<div class="column-count-is-2">
<ol>
{% for item in group.items %}
<li class="word-wrap-anywhere"><code>{{ item.name }}</code> {% if item.is_inherited %}{{ item.is_inherited }}{% endif %}</li>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's a minor formatting issue here that results in an extraneous trailing space when item.is_inherited is not present. This happens because the space before the if statement is unconditional. Moving the space inside the conditional block will ensure it only appears when needed.

          <li class="word-wrap-anywhere"><code>{{ item.name }}</code>{% if item.is_inherited %} {{ item.is_inherited }}{% endif %}</li>

{% endfor %}
</ol>
</div>
{% endfor %}
</ol></div>
</div>