Skip to content

Webpage to display a set of benchmarks from RustPython #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 6, 2021
Merged

Webpage to display a set of benchmarks from RustPython #43

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1c503a5
Adds a benchmark page to the website
theangryhobbit Mar 18, 2021
6be1576
Create tabs on benchmakrs page with benchmakrs for each tab
theangryhobbit Mar 25, 2021
038aad6
Add zero folders found check, thus no benchmarks to be displayed
theangryhobbit Mar 30, 2021
c47d73b
Update indentation
theangryhobbit Mar 30, 2021
f9c5006
Update assets/js/tabs.js based on suggested change
theangryhobbit Apr 1, 2021
ef898d2
Update assets/js/tabs.js based on suggested change
theangryhobbit Apr 1, 2021
745041f
Update assets/js/tabs.js based on suggested change
theangryhobbit Apr 1, 2021
372f442
Update assets/js/tabs.js based on suggested change
theangryhobbit Apr 1, 2021
2be423e
Fix indentation based on PR suggestion
theangryhobbit Apr 1, 2021
b7003e7
Merge remote-tracking branch 'origin/master'
theangryhobbit Apr 1, 2021
d67dbc5
Use more efficient code block and remove the other (based on suggestion)
theangryhobbit Apr 1, 2021
aaffc4c
Adds benchmark intro to _config file and updates the UI a bit
theangryhobbit Apr 1, 2021
903a873
Removes the benchmarks from the navbar
theangryhobbit Apr 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update assets/js/tabs.js based on suggested change 
Using const for objects

Co-authored-by: Niels Bauman <33722607+nielsbauman@users.noreply.github.com>
  • Loading branch information
@theangryhobbit @nielsbauman
theangryhobbit and nielsbauman authored Apr 1, 2021
commit 372f442a3bbe958e8b01814ee07660eeb3840ee6
5 changes: 3 additions & 2 deletions assets/js/tabs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,9 @@ window.addEventListener('load', function () {
}

removeActiveClasses(ulTab);
tabContentId = ulTab.getAttribute('data-tab');
tabContentElement = document.getElementById(tabContentId);
const tabContentId = ulTab.getAttribute('data-tab');
const tabContentElement = document.getElementById(tabContentId);

removeActiveClasses(tabContentElement);

tabContentElement.querySelectorAll('li')[position].classList.add('active');
Expand Down