Skip to content

Show notes for skipped tests if they exist and add support for expectedFailure test results #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 29, 2020
Merged

Show notes for skipped tests if they exist and add support for expectedFailure test results #13

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bb88986
Update Bundler version
coolreader18 May 27, 2020
20877cf
Display skip notes for skipped tests
coolreader18 May 27, 2020
cb07a7e
Minify the html tables
coolreader18 May 27, 2020
ddd98cb
Link to the regression tests in some more places
coolreader18 May 28, 2020
1f74097
Update with new test data with expected_failure result types
coolreader18 May 28, 2020
8bab8e7
Add support for expectedFailure test results
coolreader18 May 28, 2020
e6ade81
Tiny update to unittest tutorial
coolreader18 May 28, 2020
37d6700
Update data with num_expected_failures
coolreader18 May 29, 2020
dfbd211
Replace skipped summary color w/ expected failure and failed with ski…
coolreader18 May 29, 2020
dea4d42
'Summary-only' view
coolreader18 May 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Display skip notes for skipped tests
  • Loading branch information
@coolreader18
coolreader18 committed May 27, 2020
commit 20877cff57a53b570d9d98f3e751649eb0e8b134
18 changes: 17 additions & 1 deletion _layouts/regrtests_results.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,23 @@ <h2 class="font-secondary">Summary:</span>
{% if case.result %}
<div class="cell {{case.result }} results-case-list-item text-mobile-right">
<span class="text-small text-muted d-mobile-none">RESULT:</span>
{{case.result }}
<span class="case-result">{{case.result }}</span>
{%- if case.result == "skipped" -%}
{%- assign note = case.note | default: result.note-%}
{%- assign lownote = note | downcase -%}
{%- if lownote contains "todo: rustpython" -%}
{%- assign note = lownote | remove: "todo: rustpython," | remove: "todo: rustpython:" | remove: "todo: rustpython" | strip -%}
{%- if note and note != "" %}
<span class="text-small text-muted d-mobile-none">TO RESOLVE:</span>
<span class="d-mobile-none case-note">{{ note }}</span>
{%- endif -%}
{%- elsif note == "implementation detail specific to cpython" -%}
<span class="text-small text-muted d-mobile-none">(CPython only)</span>
{%- else -%}
<span class="text-small text-muted d-mobile-none">not skipped by us:</span>
<span class="text-small d-mobile-none case-note">{{ note }}</span>
{%- endif -%}
{%- endif -%}
</div>
{% endif %}

Expand Down
4 changes: 2 additions & 2 deletions assets/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,12 +315,12 @@ ul.list-inline {
padding: 5px;
}

.passed::after {
.passed > .case-result::after {
content: " 🚀 👌";
padding: 5px;
}

.skipped::after {
.skipped > .case-result::after {
content: " 🤷‍♀️";
}

Expand Down