fix: add symlink support to list_files tool (#4654)

[hannesrudolph]

Description

Fixes #4654

Adds symlink support to the list_files tool by including the --follow flag in ripgrep arguments. This enables Roo to see and traverse symbolic links when listing files, resolving the issue where symlinked files and folders were not being detected.

Changes Made

• Fixed buildRipgrepArgs(): Added "--follow" flag to base ripgrep arguments array
• Added comprehensive unit tests: Created src/services/glob/__tests__/list-files.spec.ts with tests for both recursive and non-recursive modes
• Added E2E test: Extended apps/vscode-e2e/src/suite/tools/list-files.test.ts with symlink functionality test case
• Consistent with existing patterns: Aligns with file-search.ts and ShadowCheckpointService.ts which already use --follow

Testing

• All existing tests pass (2327 tests passed, 206 test files passed)
• Added unit tests verify --follow flag inclusion for both recursive and non-recursive modes
• E2E test validates symlink functionality with actual filesystem operations
• Manual testing confirms symlinked files are now properly detected
• Linting and type checking pass

Verification of Acceptance Criteria

• Root cause identified: Missing --follow flag in buildRipgrepArgs function
• Fix implemented: Added "--follow" to base ripgrep arguments
• Symlink traversal enabled: list_files tool now follows symbolic links
• No breaking changes: Minimal, targeted fix that maintains backward compatibility
• Test coverage: Comprehensive unit and integration tests added
• Consistent patterns: Follows existing codebase conventions

Checklist

• Code follows project style guidelines
• Self-review completed
• Comments added for complex logic
• Documentation updated (if needed)
• No breaking changes
• All tests passing
• Linting and type checking pass

Technical Details

The fix was minimal and surgical - adding a single "--follow" argument to the ripgrep command construction in the buildRipgrepArgs function. This enables the underlying ripgrep tool to traverse symbolic links when listing files.

Before: const args = ["--files", "--hidden"]
After: const args = ["--files", "--hidden", "--follow"]

This resolves Josh's use case of organizing multiple codebases using symlinks for integration tasks, as mentioned in the original issue.

---

Important

Adds symlink support to list_files tool by including --follow flag in buildRipgrepArgs() and updates tests.

• Behavior:
  • Adds --follow flag to buildRipgrepArgs() in list-files.ts to enable symlink traversal.
  • list_files tool now detects symlinked files and directories.
• Testing:
  • Adds unit tests in list-files.spec.ts to verify --follow flag inclusion for recursive and non-recursive modes.
  • Extends E2E test in list-files.test.ts to validate symlink functionality.
• Consistency:
  • Aligns with existing usage of --follow in file-search.ts and ShadowCheckpointService.ts.

^{This description was created by for a232e5a. You can customize this summary. It will automatically update as commits are pushed.}

[Copilot]

Pull Request Overview

This PR fixes issue #4654 by adding symlink support to the list_files tool using ripgrep's "--follow" flag so that symbolic links are traversed during file listing.

• Added "--follow" to the ripgrep arguments in buildRipgrepArgs.
• Introduced unit tests validating flag inclusion for both recursive and non-recursive modes.
• Extended an E2E test to verify that symlinked files and directories are correctly listed.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/services/glob/list-files.ts	Updated buildRipgrepArgs to include the "--follow" flag for symlink traversal.
src/services/glob/tests/list-files.spec.ts	Added unit tests to confirm the "--follow" flag is present when invoking the tool.
apps/vscode-e2e/src/suite/tools/list-files.test.ts	Extended E2E tests to verify that symlinked files and directories are detected.

Comments suppressed due to low confidence (1)

src/services/glob/list-files.ts:96

• Consider adding an inline comment indicating that the "--follow" flag enables symlink traversal to help maintain clarity for future maintainers.

	const args = ["--files", "--hidden", "--follow"]

[hannesrudolph]

Thanks for this PR! I've reviewed the changes and the implementation looks solid.

Summary

This PR successfully addresses issue #4654 by adding symlink support to the list_files tool through a minimal, targeted fix - adding the --follow flag to ripgrep arguments in the buildRipgrepArgs() function.

What I liked

✅ Minimal and surgical fix: The change is exactly what's needed - just adding "--follow" to the base ripgrep arguments array. No unnecessary complexity.

✅ Consistency with existing patterns: I verified that this aligns with how --follow is already used in file-search.ts and ShadowCheckpointService.ts, maintaining consistency across the codebase.

✅ Comprehensive test coverage:

• Unit tests properly verify the --follow flag is included for both recursive and non-recursive modes
• E2E test validates actual symlink functionality with filesystem operations
• Tests gracefully handle platforms that don't support symlinks

✅ Backward compatibility: The change doesn't introduce any breaking changes - existing functionality remains intact while adding the new capability.

Technical correctness

The implementation correctly adds the --follow flag to the base arguments array, ensuring it's applied in both recursive and non-recursive modes. This enables ripgrep to traverse symbolic links when listing files, which directly addresses the issue reported by Josh.

Overall assessment

This is a well-crafted PR that demonstrates good engineering practices:

• Clear problem identification and targeted solution
• Proper test coverage at multiple levels
• Consistency with existing codebase patterns
• No unnecessary changes or scope creep

The PR successfully enables the list_files tool to detect symlinked files and directories, resolving the user's use case of organizing multiple codebases using symlinks for integration tasks.

Great work! 🎉

[daniel-lxs]

Tested, LGTM