PDF files damaged

[julkah]

Some pdf files are damaged when downloaded via syncMyMoodle. Downloading the same file using moodle's web interface doesn't yield this damaged file.

[Romern]

Damaged meaning the downloaded file contains the moodle error page "Die gesuchte Datei wurde nicht gefunden."

[septatrix]

Could you share such a damaged file? I also recently stumbled upon some of those however for me it seemed like the session timed out as the content was just the HTML content of the login page.

[septatrix]

This specific PDF file was reachable under a the url .../mod_page/content/3/foobar.pdf - which for some reason gets modified since ea17a29. The result is a wrong URL...

[septatrix]

syncMyMoodle/syncmymoodle/__main__.py

Line 43 in 4bcb51f

url = url.replace("?forcedownload=1","").replace("mod_page/content/3","mod_page/content")

@julkah Do you mind removing this line as well as the local pdf and re-running smm to check if that fixes it? (The second replace is presumably at fault here though I also cannot think of a reason for the former.)

[n0toose]

Has this issue been resolved?

[septatrix]

Nope, only on v2 branch though it is untested there.