chore!: remove deprecated livechat:returnAsInquiry method

[juliajforesti]

ARCH-1860

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

• Breaking Changes
  • Removed a deprecated livechat method for inquiry conversion. Users should migrate to the v1 REST API for continued functionality.

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: 7c59d0c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages

Name	Type
@rocket.chat/meteor	Major
@rocket.chat/core-typings	Major
@rocket.chat/rest-typings	Major
@rocket.chat/uikit-playground	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/freeswitch	Patch
@rocket.chat/fuselage-ui-kit	Major
@rocket.chat/gazzodown	Major
@rocket.chat/http-router	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-avatar	Major
@rocket.chat/ui-client	Major
@rocket.chat/ui-contexts	Major
@rocket.chat/web-ui-registration	Major
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/federation-matrix	Patch
@rocket.chat/license	Patch
@rocket.chat/media-calls	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/models	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/omni-core-ee	Patch
@rocket.chat/mock-providers	Patch
@rocket.chat/ui-video-conf	Major
@rocket.chat/ui-voip	Major
@rocket.chat/instance-status	Patch
@rocket.chat/omni-core	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Walkthrough

This pull request removes the deprecated livechat:returnAsInquiry Meteor method from the codebase. The changes include a changeset file declaring a major version bump with a breaking change, removal of the method's import from the server initialization, and deletion of the method implementation file containing the full logic.

Changes

Cohort / File(s)	Summary
Changeset .changeset/five-months-shake.md	Adds changeset documenting major version bump for @rocket.chat/meteor with breaking change: removal of deprecated livechat:returnAsInquiry method.
Livechat Server apps/meteor/app/livechat/server/index.ts, apps/meteor/app/livechat/server/methods/returnAsInquiry.ts	Removes import of returnAsInquiry module from server initialization and deletes the method file entirely, eliminating the Meteor method livechat:returnAsInquiry that validated permissions, room type, and delegated to a helper for room-to-inquiry conversion.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Verify the method is not called elsewhere in the codebase
• Confirm the deprecation warning in related PR #36973 was deployed before this removal
• Check that all clients have migrated to the REST endpoint alternative

Possibly related PRs

• PR #36973: Adds deprecation notice and new REST endpoint for livechat:returnAsInquiry, serving as the predecessor to this removal.

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

• juliajforesti
• KevLehman
• sampaiodiego

Poem

🐰 A method once lived in the chat,
Deprecated now, imagine that!
With hopping delight, we say goodbye,
To returnAsInquiry—time to fly! 🚀

Pre-merge checks and finishing touches

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title 'chore!: remove deprecated livechat:returnAsInquiry method' clearly summarizes the main change: removal of a deprecated Meteor method from the livechat module.
Linked Issues check	✅ Passed	The linked issue ARCH-1860 has no specified coding requirements provided. The PR implements removal of the deprecated livechat:returnAsInquiry method and updates related imports and changeset files, which aligns with the issue title.
Out of Scope Changes check	✅ Passed	All changes are directly related to removing the deprecated livechat:returnAsInquiry method: deletion of the method file, removal of its import, and addition of a changeset entry. No unrelated modifications are present.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/remove-returnAsInquiry

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ba732f5 and 7c59d0c.

📒 Files selected for processing (3)

• .changeset/five-months-shake.md (1 hunks)
• apps/meteor/app/livechat/server/index.ts (0 hunks)
• apps/meteor/app/livechat/server/methods/returnAsInquiry.ts (0 hunks)

💤 Files with no reviewable changes (2)

• apps/meteor/app/livechat/server/index.ts
• apps/meteor/app/livechat/server/methods/returnAsInquiry.ts

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-09-19T15:15:04.642Z

Learnt from: rodrigok
Repo: RocketChat/Rocket.Chat PR: 36991
File: apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts:219-221
Timestamp: 2025-09-19T15:15:04.642Z
Learning: The Federation_Matrix_homeserver_domain setting in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts is part of the old federation system and is being deprecated/removed, so configuration issues with this setting should not be flagged for improvement.

Applied to files:

• .changeset/five-months-shake.md

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: 🔨 Test Unit / Unit Tests
• GitHub Check: 🔎 Code Check / Code Lint
• GitHub Check: 🔎 Code Check / TypeScript
• GitHub Check: 📦 Meteor Build (production)
• GitHub Check: 📦 Meteor Build (coverage)
• GitHub Check: CodeQL-Build

🔇 Additional comments (1)

.changeset/five-months-shake.md (1)

1-5: Changeset correctly documents complete removal of deprecated Meteor Method.

The deprecated Meteor Method livechat:returnAsInquiry has been completely removed from the codebase (no file references or server registrations remain). The REST endpoint livechat/inquiries.returnAsInquiry intentionally remains as the modern replacement—these are distinct APIs and should not be confused. The changeset format is correct and the major version bump is appropriate.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.92%. Comparing base (8728dd6) to head (7c59d0c).
⚠️ Report is 5 commits behind head on release-8.0.0.

Additional details and impacted files

@@                Coverage Diff                @@
##           release-8.0.0   #37392      +/-   ##
=================================================
- Coverage          72.30%   70.92%   -1.38%     
=================================================
  Files               1494     3036    +1542     
  Lines              77102   104609   +27507     
  Branches           10935    18419    +7484     
=================================================
+ Hits               55746    74196   +18450     
- Misses             20940    28461    +7521     
- Partials             416     1952    +1536     

Flag	Coverage Δ
e2e	58.05% <ø> (?)
unit	72.28% <ø> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.