Skip to content

Conversation

@ergot-rp
Copy link
Contributor

@ergot-rp ergot-rp commented Oct 2, 2025

For WCAG compability, a fieldset must have a legend. The FieldGroup-component used in the profile-page returns a fieldset. To assure WCAG-compability a visually hidden fieldset is added

WA-62

Summary by CodeRabbit

  • New Features
    • Improved accessibility in the profile form by adding a screen-reader-only label for the profile details section, enhancing navigation and context for assistive technology users with no visible UI changes.
  • Refactor
    • Standardized the status text length validation to a clearer, multi-line rules format for consistency; validation behavior remains unchanged.

@ergot-rp ergot-rp requested a review from a team as a code owner October 2, 2025 13:30
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 2, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2025

🦋 Changeset detected

Latest commit: 2a4d05a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 41 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/federation-matrix Patch
@rocket.chat/license Patch
@rocket.chat/media-calls Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ dougfabris
❌ ergotse
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 2, 2025

Walkthrough

Adds an invisible accessible label for the profile details fieldset and restructures the statusText maxLength validation into an explicit multi-line rules object; also adds a changeset entry bumping @rocket.chat/meteor.

Changes

Cohort / File(s) Summary
Accessibility & validation
apps/meteor/client/views/account/profile/AccountProfileForm.tsx
Added a VisuallyHidden wrapper to provide an accessible label for the profile details fieldset; refactored statusText maxLength rule into a multi-line rules object (no API/export changes).
Release metadata
.changeset/dull-rocks-boil.md
Added a changeset that bumps @rocket.chat/meteor with a note about adding the missing legend for WCAG compliance.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Potential review focus:

  • Confirm VisuallyHidden usage and semantics meet screen-reader expectations.
  • Verify statusText validation object shape still integrates with existing form validation logic.
  • Ensure the changeset metadata is correctly formatted.

Poem

In hush of forms where legends hide,
I bury words so screens can guide.
Rules now tidy, lengths defined,
A rabbit nods — accessibility aligned. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: adding a missing legend to a FieldGroup component on the profile page for accessibility compliance.
Linked Issues check ✅ Passed The PR successfully addresses WA-62 by adding a visually hidden legend to the fieldset in the FieldGroup component on the profile page, meeting WCAG requirements.
Out of Scope Changes check ✅ Passed All changes are directly scoped to addressing the WCAG compliance issue: adding a legend wrapper and updating validation structure in the profile form, with no unrelated modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9d80181 and 04902d0.

📒 Files selected for processing (1)
  • .changeset/dull-rocks-boil.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: 📦 Build Packages
  • GitHub Check: CodeQL-Build
🔇 Additional comments (1)
.changeset/dull-rocks-boil.md (1)

1-5: Changeset structure and description look good.

The YAML frontmatter is correctly formatted, the version bump to minor is appropriate for an accessibility improvement without breaking changes, and the changelog entry clearly describes the WCAG compliance fix.

However, the AI summary mentions that the PR also refactors the statusText maxLength validation into an explicit multi-line rules object in AccountProfileForm.tsx. If this refactor is a user-facing change or a significant structural change to the validation logic, consider whether it warrants a mention in the changelog entry.

Verify that the actual code changes in AccountProfileForm.tsx align with what's described in this changeset, particularly around the legend implementation and any validation refactoring.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the stylelint errors, try running our stylelint script

@dougfabris dougfabris changed the title fix: (1.3.1) Added a visually hidden legend fix(a11y): Missing FieldGroup legend in profile page Nov 11, 2025
@dougfabris dougfabris changed the title fix(a11y): Missing FieldGroup legend in profile page feat(a11y): Missing FieldGroup legend in profile page Nov 11, 2025
@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Nov 11, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 11, 2025
@kodiakhq kodiakhq bot merged commit 7d90c9d into RocketChat:develop Nov 13, 2025
75 of 82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants