Skip to content

Conversation

@lucas-a-pelegrino
Copy link
Member

@lucas-a-pelegrino lucas-a-pelegrino commented Sep 11, 2025

Proposed changes (including videos or screenshots)

This PR removes the livechat:getRoutingConfig deprecated meteor method.

Issue(s)

CTZ-56

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • Breaking Changes

    • Removed the Livechat Realtime API method livechat:getRoutingConfig. Integrations relying on this method must migrate to supported alternatives.
  • Chores

    • Upgraded @rocket.chat/meteor to a new major version to align with the API change and compatibility updates.

@lucas-a-pelegrino lucas-a-pelegrino added this to the 8.0.0 milestone Sep 11, 2025
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 11, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2025

🦋 Changeset detected

Latest commit: cc87d21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/federation-matrix Patch
@rocket.chat/license Patch
@rocket.chat/media-calls Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 11, 2025

Walkthrough

Removes the deprecated Realtime (DDP) method livechat:getRoutingConfig by deleting its server method and DDP type augmentation, removes its side-effect import from the livechat server index, and adds a changeset declaring a major bump for @rocket.chat/meteor.

Changes

Cohort / File(s) Summary
Livechat routing config method removal
apps/meteor/app/livechat/server/index.ts, apps/meteor/app/livechat/server/methods/getRoutingConfig.ts
Removed the side-effect import from the livechat server index and deleted the Meteor server method registration and TypeScript DDP augmentation for livechat:getRoutingConfig.
Release changeset
.changeset/selfish-countries-sleep.md
Adds a changeset declaring a major version bump for @rocket.chat/meteor and documenting removal of the deprecated Realtime API method livechat:getRoutingConfig.

Sequence Diagram(s)

sequenceDiagram
  actor Client
  participant DDP_Server as Realtime (DDP) Server

  Note over Client,DDP_Server: Prior behavior (removed)
  Client->>DDP_Server: call "livechat:getRoutingConfig"
  DDP_Server-->>Client: OmnichannelRoutingConfig

  rect rgba(255,230,230,0.6)
  Note over Client,DDP_Server: After removal (current)
  Client->>DDP_Server: call "livechat:getRoutingConfig"
  DDP_Server-->>Client: Method not found / error
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Potential files to pay extra attention to:

  • apps/meteor/app/livechat/server/index.ts — ensure no other side-effect imports relied on removed module.
  • Any consumers of the DDP method elsewhere in the codebase or tests.

Possibly related PRs

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

  • aleksandernsilva
  • sampaiodiego

Poem

A rabbit trims the routing thread,
Old calls vanish, softly shed.
DDP's door now closed and neat,
New endpoints tap a steadier beat. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Linked Issues check ❓ Inconclusive The PR removes the deprecated 'livechat:getRoutingConfig' method as required. However, insufficient context is provided in the linked issue to fully validate all coding requirements and objectives. Provide more details about the requirements in linked issue CTZ-56 or CORE-1451 to fully validate that all coding objectives are met.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore!: removes livechat:getRoutingConfig deprecated method' clearly and specifically describes the main change: removal of a deprecated Realtime API method, which matches the changeset and file deletions.
Out of Scope Changes check ✅ Passed All changes are directly related to removing the deprecated 'livechat:getRoutingConfig' method: the changeset file, import removal, and file deletion are all in scope.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/v8/CTZ-56

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between e135a26 and cc87d21.

📒 Files selected for processing (3)
  • .changeset/selfish-countries-sleep.md (1 hunks)
  • apps/meteor/app/livechat/server/index.ts (0 hunks)
  • apps/meteor/app/livechat/server/methods/getRoutingConfig.ts (0 hunks)
💤 Files with no reviewable changes (2)
  • apps/meteor/app/livechat/server/methods/getRoutingConfig.ts
  • apps/meteor/app/livechat/server/index.ts
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: rodrigok
Repo: RocketChat/Rocket.Chat PR: 36991
File: apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts:219-221
Timestamp: 2025-09-19T15:15:04.642Z
Learning: The Federation_Matrix_homeserver_domain setting in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts is part of the old federation system and is being deprecated/removed, so configuration issues with this setting should not be flagged for improvement.
📚 Learning: 2025-09-19T15:15:04.642Z
Learnt from: rodrigok
Repo: RocketChat/Rocket.Chat PR: 36991
File: apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts:219-221
Timestamp: 2025-09-19T15:15:04.642Z
Learning: The Federation_Matrix_homeserver_domain setting in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts is part of the old federation system and is being deprecated/removed, so configuration issues with this setting should not be flagged for improvement.

Applied to files:

  • .changeset/selfish-countries-sleep.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: 📦 Build Packages
  • GitHub Check: CodeQL-Build
  • GitHub Check: CodeQL-Build
🔇 Additional comments (1)
.changeset/selfish-countries-sleep.md (1)

1-5: Client-side callers have been successfully updated — verification complete.

All references to livechat:getRoutingConfig have been removed from OmnichannelProvider.tsx, queueManager.ts, and the rest of the codebase. The method removal will not cause runtime failures on the client side.

The changeset is ready to proceed.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.79%. Comparing base (8fa1cac) to head (cc87d21).
⚠️ Report is 1 commits behind head on release-8.0.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-8.0.0   #36924      +/-   ##
=================================================
+ Coverage          70.74%   70.79%   +0.05%     
=================================================
  Files               3024     3024              
  Lines             103618   103618              
  Branches           18329    18338       +9     
=================================================
+ Hits               73300    73356      +56     
+ Misses             28380    28322      -58     
- Partials            1938     1940       +2     
Flag Coverage Δ
e2e 58.00% <ø> (+0.04%) ⬆️
unit 72.16% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5467e46 and a3ed925.

📒 Files selected for processing (3)
  • .changeset/selfish-countries-sleep.md (1 hunks)
  • apps/meteor/app/livechat/server/index.ts (0 hunks)
  • apps/meteor/app/livechat/server/methods/getRoutingConfig.ts (0 hunks)
💤 Files with no reviewable changes (2)
  • apps/meteor/app/livechat/server/index.ts
  • apps/meteor/app/livechat/server/methods/getRoutingConfig.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: 🔨 Test Storybook / Test Storybook
  • GitHub Check: 🔎 Code Check / TypeScript
  • GitHub Check: 🔎 Code Check / Code Lint
  • GitHub Check: 🔨 Test Unit / Unit Tests
  • GitHub Check: 📦 Meteor Build - coverage
  • GitHub Check: CodeQL-Build
  • GitHub Check: CodeQL-Build
🔇 Additional comments (1)
.changeset/selfish-countries-sleep.md (1)

1-3: Changeset frontmatter looks valid.

Package bump is marked as major for "@rocket.chat/meteor" with proper changeset syntax.

juliajforesti
juliajforesti previously approved these changes Oct 6, 2025
@juliajforesti juliajforesti marked this pull request as ready for review October 7, 2025 13:31
@juliajforesti juliajforesti requested a review from a team as a code owner October 7, 2025 13:31
@ggazzo ggazzo dismissed juliajforesti’s stale review October 31, 2025 17:40

The merge-base changed after approval.

@ggazzo ggazzo requested review from a team as code owners October 31, 2025 17:40
@ggazzo ggazzo force-pushed the release-8.0.0 branch 4 times, most recently from 329ef07 to 8fa1cac Compare October 31, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants