-
Notifications
You must be signed in to change notification settings - Fork 12.9k
chore!: removes livechat:getRoutingConfig deprecated method
#36924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: cc87d21 The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughRemoves the deprecated Realtime (DDP) method Changes
Sequence Diagram(s)sequenceDiagram
actor Client
participant DDP_Server as Realtime (DDP) Server
Note over Client,DDP_Server: Prior behavior (removed)
Client->>DDP_Server: call "livechat:getRoutingConfig"
DDP_Server-->>Client: OmnichannelRoutingConfig
rect rgba(255,230,230,0.6)
Note over Client,DDP_Server: After removal (current)
Client->>DDP_Server: call "livechat:getRoutingConfig"
DDP_Server-->>Client: Method not found / error
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Potential files to pay extra attention to:
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings📚 Learning: 2025-09-19T15:15:04.642ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.0.0 #36924 +/- ##
=================================================
+ Coverage 70.74% 70.79% +0.05%
=================================================
Files 3024 3024
Lines 103618 103618
Branches 18329 18338 +9
=================================================
+ Hits 73300 73356 +56
+ Misses 28380 28322 -58
- Partials 1938 1940 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.changeset/selfish-countries-sleep.md(1 hunks)apps/meteor/app/livechat/server/index.ts(0 hunks)apps/meteor/app/livechat/server/methods/getRoutingConfig.ts(0 hunks)
💤 Files with no reviewable changes (2)
- apps/meteor/app/livechat/server/index.ts
- apps/meteor/app/livechat/server/methods/getRoutingConfig.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: 🔨 Test Storybook / Test Storybook
- GitHub Check: 🔎 Code Check / TypeScript
- GitHub Check: 🔎 Code Check / Code Lint
- GitHub Check: 🔨 Test Unit / Unit Tests
- GitHub Check: 📦 Meteor Build - coverage
- GitHub Check: CodeQL-Build
- GitHub Check: CodeQL-Build
🔇 Additional comments (1)
.changeset/selfish-countries-sleep.md (1)
1-3: Changeset frontmatter looks valid.Package bump is marked as major for "@rocket.chat/meteor" with proper changeset syntax.
f6eaabb to
70fdc50
Compare
3c49b49 to
fd14b03
Compare
fd14b03 to
e135a26
Compare
The merge-base changed after approval.
329ef07 to
8fa1cac
Compare
e135a26 to
cc87d21
Compare
Proposed changes (including videos or screenshots)
This PR removes the
livechat:getRoutingConfigdeprecated meteor method.Issue(s)
CTZ-56
Steps to test or reproduce
Further comments
Summary by CodeRabbit
Breaking Changes
Chores