Skip to content

Conversation

@abhinavkrin
Copy link
Member

@abhinavkrin abhinavkrin commented Sep 1, 2025

Proposed changes (including videos or screenshots)

Removes deprecated appId parameter from the oauth-apps.get endpoint.

Issue(s)

Steps to test or reproduce

Further comments

ARCH-1742

Summary by CodeRabbit

  • Chores
    • Major version bump.
    • Removed deprecated appId support from the oauth-apps.get endpoint; it now accepts only _id or clientId.
  • Tests
    • Removed tests related to appId-based retrieval and associated validation cases.
  • Documentation
    • Updated release notes metadata to reflect the removal of appId from oauth-apps.get.

@abhinavkrin abhinavkrin requested a review from a team as a code owner September 1, 2025 15:25
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 1, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2025

🦋 Changeset detected

Latest commit: c9624dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 38 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@abhinavkrin abhinavkrin added this to the 8.0.0 milestone Sep 1, 2025
@abhinavkrin abhinavkrin changed the base branch from develop to release-8.0.0 September 1, 2025 15:26
@abhinavkrin abhinavkrin requested review from a team as code owners September 1, 2025 15:26
@abhinavkrin abhinavkrin force-pushed the chore/remove-appId-parameter-from-oauth-apps.get branch from 8d3df4a to 0135505 Compare September 1, 2025 15:29
@codecov
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.37%. Comparing base (3c42f0d) to head (c9624dd).
⚠️ Report is 98 commits behind head on release-8.0.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-8.0.0   #36849      +/-   ##
=================================================
- Coverage          66.43%   66.37%   -0.07%     
=================================================
  Files               3276     3312      +36     
  Lines             109596   111670    +2074     
  Branches           20860    20940      +80     
=================================================
+ Hits               72814    74121    +1307     
- Misses             34116    34872     +756     
- Partials            2666     2677      +11     
Flag Coverage Δ
e2e 58.26% <ø> (+0.41%) ⬆️
unit 70.86% <ø> (-0.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo changed the title chore!: remove deprecated appId parameter from oauth-apps.get ednpoint chore!: remove deprecated appId parameter from oauth-apps.get endpoint Sep 1, 2025
@abhinavkrin abhinavkrin force-pushed the chore/remove-appId-parameter-from-oauth-apps.get branch from accffef to 424744f Compare September 1, 2025 17:58
d-gubert
d-gubert previously approved these changes Sep 1, 2025
@d-gubert d-gubert added the stat: QA assured Means it has been tested and approved by a company insider label Sep 1, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 1, 2025
@ggazzo ggazzo dismissed d-gubert’s stale review September 4, 2025 18:47

The merge-base changed after approval.

@ggazzo ggazzo force-pushed the release-8.0.0 branch 3 times, most recently from e3a8829 to e19fae0 Compare September 4, 2025 19:01
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Sep 4, 2025
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Sep 4, 2025

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Removes deprecated `appId` parameter from the `oauth-apps.get` endpoint.
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
@MartinSchoeler MartinSchoeler force-pushed the chore/remove-appId-parameter-from-oauth-apps.get branch from 424744f to c9624dd Compare September 15, 2025 16:22
ggazzo pushed a commit that referenced this pull request Oct 31, 2025
#36849)

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Oct 31, 2025
#36849)

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Oct 31, 2025
#36849)

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Nov 4, 2025
#36849)

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Nov 5, 2025
#36849)

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Nov 5, 2025
#36849)

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Nov 5, 2025
#36849)

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Nov 6, 2025
#36849)

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Nov 12, 2025
#36849)

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Nov 12, 2025
#36849)

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Nov 13, 2025
#36849)

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Nov 18, 2025
#36849)

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Dec 2, 2025
#36849)

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Dec 9, 2025
#36849)

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Dec 10, 2025
#36849)

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Dec 15, 2025
#36849)

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Dec 17, 2025
#36849)

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Dec 17, 2025
#36849)

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Dec 17, 2025
#36849)

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Dec 18, 2025
#36849)

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Dec 18, 2025
#36849)

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Dec 18, 2025
#36849)

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Dec 19, 2025
#36849)

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Dec 19, 2025
#36849)

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Dec 19, 2025
#36849)

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Dec 20, 2025
#36849)

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Dec 20, 2025
#36849)

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Dec 20, 2025
#36849)

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
dougfabris pushed a commit that referenced this pull request Dec 20, 2025
#36849)

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants