Skip to content

feat: Add message timestamp picker components for date and time selection #36595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 39 commits into from
Oct 28, 2025
Merged

feat: Add message timestamp picker components for date and time selection #36595

kodiakhq merged 39 commits into from
Oct 28, 2025

Conversation

@jhanyu2019
Copy link
Contributor

@jhanyu2019 jhanyu2019 commented Aug 1, 2025 •
edited by dougfabris
Loading

Proposed changes (including videos or screenshots)

Added a TimestampPicker modal that allows users to select a date, time, format, and timezone, then preview the generated timestamp before sending it in the message input.

Screenshot 2025-09-30 at 09 45 12

COMM-11

Steps to test or reproduce

  1. Go to message box
  2. Click "More actions" (plus icon)
  3. Select "Add Date And Time"
  4. Choose your date, time, format, and timezone
  5. Confirm preview and click "Add" – the timestamp should be inserted into the message input as expected

Further comments

@coderabbitai ignore

jhanyu2019 and others added 11 commits May 20, 2025 16:15
@jhanyu2019
Initial GSoC implementation: timestamp picker components and integrat…
258a799 
…ion hook
@jhanyu2019
Apply PR feedback: clean up duplicate code and apply additional fixes
2860374
@jhanyu2019
Apply PR feedback: fix preview feature and address lint/stylelint issues
49ee488
@jhanyu2019
sync tsconfig and ui-kit config files with upstream
ab9f0d0
@MartinSchoeler
Revert "sync tsconfig and ui-kit config files with upstream"
08d3de2 
This reverts commit ab9f0d0.
@MartinSchoeler
Merge branch 'develop' into feature/gsoc-timestamp-picker
b3e1b4a
@MartinSchoeler
fix: Fixes build & Page errors
2e3711d
@jhanyu2019
feat: add timezone support to TimestampPicker and fix Preview logic
30756c2
@jhanyu2019
fix: update timezone logic, migrate useState to react-hook-form, add …
ea464f1 
…i18n support
@jhanyu2019
test: add TimestampPicker test and improve robustness for empty date/…
c4ed23d 
…time inputs
@jhanyu2019
Merge remote-tracking branch 'upstream/develop' into feature/gsoc-tim…
47128d2 
…estamp-picker
@jhanyu2019 jhanyu2019 requested a review from a team as a code owner August 1, 2025 03:42
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Aug 1, 2025 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.13.0, but it targets 7.12.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Aug 1, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 062bee8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Aug 1, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@MartinSchoeler MartinSchoeler requested review from a team and MartinSchoeler August 29, 2025 19:35
coderabbitai[bot]

This comment was marked as off-topic.

Sign in to view

@RocketChat RocketChat deleted a comment from coderabbitai bot Sep 11, 2025
@dougfabris dougfabris force-pushed the feature/gsoc-timestamp-picker branch from e75a935 to af7e519 Compare September 29, 2025 18:53
dougfabris
dougfabris previously approved these changes Sep 30, 2025
View reviewed changes
MartinSchoeler
MartinSchoeler previously approved these changes Oct 1, 2025
View reviewed changes
@julio-rocketchat julio-rocketchat self-requested a review October 13, 2025 17:54
@dougfabris dougfabris dismissed stale reviews from julio-rocketchat, MartinSchoeler, and themself via 3c1677d October 13, 2025 23:12
dougfabris
dougfabris previously approved these changes Oct 13, 2025
View reviewed changes
@scuciatto scuciatto modified the milestones: 7.12.0, 7.13.0 Oct 20, 2025
@scuciatto scuciatto added the stat: QA assured Means it has been tested and approved by a company insider label Oct 27, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 27, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Oct 28, 2025
@dougfabris dougfabris added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels Oct 28, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 28, 2025
@kodiakhq kodiakhq bot merged commit 6f4362b into RocketChat:develop Oct 28, 2025
80 of 82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@dougfabris dougfabris dougfabris approved these changes

@MartinSchoeler MartinSchoeler MartinSchoeler left review comments

@julio-rocketchat julio-rocketchat julio-rocketchat left review comments

Assignees

No one assigned

Labels

gsoc-project stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

7.13.0

Development

Successfully merging this pull request may close these issues.

6 participants

@jhanyu2019 @CLAassistant @MartinSchoeler @dougfabris @julio-rocketchat @scuciatto