Skip to content

Conversation

@blackmamba1231
Copy link
Contributor

Proposed changes

This PR removes the deprecated canAccessRoom method that was scheduled for removal after v5.0 but is still present in v7.4.0. The method was only enabled when the environment variable ALLOW_CANACCESSROOM_METHOD was set to "yes" or "true".

Changes made:

  • Removed the canAccessRoom.ts file
  • Updated the index.ts file to remove the import for the canAccessRoom method

Issue(s)

Fixes #35432

Steps to test or reproduce

  1. Verify that the canAccessRoom method is no longer available
  2. Ensure that applications using the async alternative canAccessRoomAsync continue to work correctly
  3. No functionality should be affected as this method was already deprecated and only available when explicitly enabled via environment variable

Further comments

This change is part of the ongoing effort to clean up deprecated code in the Rocket.Chat codebase. The method was marked for removal after v5.0 and we're now at v7.4.0, so it's time to complete the deprecation process.

@blackmamba1231 blackmamba1231 requested a review from a team as a code owner March 8, 2025 12:10
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 8, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 8.0.0, but it targets 7.5.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Mar 8, 2025

🦋 Changeset detected

Latest commit: 8c9d28f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Gustrb
Copy link
Contributor

Gustrb commented Mar 8, 2025

Even though this was already scheduled for removal I don't see why removing it in a minor version. We should probably wait for 8.0 so we can remove it without the concern of introducing breaking changes

@blackmamba1231
Copy link
Contributor Author

blackmamba1231 commented Mar 8, 2025

I appreciate your perspective on following semantic versioning principles. You make a valid point about avoiding breaking changes in minor versions.

While the method was marked for removal after v5.0 and is currently only enabled via an environment variable, I understand the concern about potential disruption to users who might still be relying on it.

I'm happy to adjust the PR to target v8.0 instead. Would you like me to update the PR description to reflect this timing, or would you prefer to handle this differently? I'll follow the team's guidance on the appropriate approach for handling this deprecated functionality.

@debdutdeb debdutdeb added this to the 8.0.0 milestone Mar 8, 2025
@debdutdeb debdutdeb marked this pull request as draft March 8, 2025 17:19
@blackmamba1231 blackmamba1231 marked this pull request as ready for review March 9, 2025 20:13
@ggazzo ggazzo changed the base branch from develop to release-8.0.0 May 9, 2025 21:27
@ggazzo ggazzo changed the title fix(methods): remove deprecated canAccessRoom method chore!(meteor-methods): remove deprecated canAccessRoom method May 9, 2025
@ggazzo ggazzo changed the title chore!(meteor-methods): remove deprecated canAccessRoom method chore(meteor-methods)!: remove deprecated canAccessRoom method May 9, 2025
@ggazzo ggazzo merged commit 8ada3f8 into RocketChat:release-8.0.0 May 12, 2025
5 of 7 checks passed
ggazzo added a commit that referenced this pull request May 14, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Jun 4, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Jun 5, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Jun 5, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Jun 5, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Jun 25, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Jul 4, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Jul 9, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Jul 29, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Aug 6, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Aug 6, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Aug 6, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Aug 6, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Sep 4, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Sep 30, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 3, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 31, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Oct 31, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Nov 4, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Nov 5, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Nov 5, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Nov 6, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Nov 12, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Nov 12, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Nov 13, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Nov 18, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 2, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 9, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 10, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 15, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 17, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 17, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 18, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 18, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 18, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 19, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 19, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 19, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 20, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 20, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo added a commit that referenced this pull request Dec 20, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
dougfabris pushed a commit that referenced this pull request Dec 20, 2025
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated canAccessRoom method still present in v7.4.0

4 participants