Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

Conversation

@rafaelks
Copy link
Contributor

@rafaelks rafaelks commented Apr 5, 2019

@RocketChat/ios

This PR adds initial support to Discussions feature.

  • User can now see discussions into the list of chats;
  • There are specific icons for Discussions;
  • Discussions will always use fname property instead of name;
  • There's a new chat item to display Discussion information and allow user to open/read it;

@rafaelks rafaelks added this to the 3.4.1 milestone Apr 5, 2019
@rafaelks rafaelks marked this pull request as ready for review April 5, 2019 13:50
@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #2646 into develop will decrease coverage by 0.14%.
The diff coverage is 6.82%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2646      +/-   ##
===========================================
- Coverage    26.17%   26.02%   -0.15%     
===========================================
  Files          463      465       +2     
  Lines        17224    17373     +149     
===========================================
+ Hits          4509     4522      +13     
- Misses       12715    12851     +136
Impacted Files Coverage Δ
Rocket.Chat/Models/Message/Message.swift 88.57% <ø> (ø) ⬆️
...Chat/Controllers/Chat/MessagesViewController.swift 31.49% <ø> (ø) ⬆️
...ontrollers/Chat/ChannelActionsViewController.swift 0% <ø> (ø) ⬆️
...at/Models/Subscription/UnmanagedSubscription.swift 0% <ø> (ø) ⬆️
...ws/Chat/New Chat/Cells/MessageDiscussionCell.swift 0% <0%> (ø)
...Controllers/Chat/ChatSections/MessageSection.swift 4.04% <0%> (-0.12%) ⬇️
...iews/Cells/Subscription/BaseSubscriptionCell.swift 0% <0%> (ø) ⬆️
...New Chat/ChatItems/MessageDiscussionChatItem.swift 0% <0%> (ø)
Rocket.Chat/Managers/AppManager.swift 34.15% <0%> (-5.96%) ⬇️
Rocket.Chat/Models/Subscription/Subscription.swift 48.97% <100%> (+2.17%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa6127f...1ec0e05. Read the comment docs.

@rafaelks rafaelks merged commit ab87674 into develop Apr 5, 2019
@rafaelks rafaelks deleted the feature/discussions branch April 5, 2019 14:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants