This repository was archived by the owner on Jun 7, 2020. It is now read-only.
[BUG][RCVC] Deleted messages are not removed from the list #2428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r createdAt since it will be required to transform the message into an Unmanaged in order to update its cache
…emove the message instead of just updating its contents
…st that is not lively affected by updates on the database, that way we can get the id of a deleted object that doesn't exists anymore on the messages query results
houndci-bot
reviewed
Dec 13, 2018
| } | ||
|
|
||
| messagesQueryOldValues = messagesQuery.compactMap({ message -> AnyHashable? in | ||
| guard let id = message.identifier else { |
There was a problem hiding this comment.
Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'id' (identifier_name)
filipealva
changed the title
cardoso
reviewed
Dec 13, 2018
rafaelks
approved these changes
Dec 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios
Closes #2383