Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

Conversation

@filipealva
Copy link
Contributor

@RocketChat/ios

Closes #2408

@filipealva filipealva changed the title [BUG] MessagesViewController keep in memory after closing chat rooms [WIP][BUG] MessagesViewController keep in memory after closing chat rooms Dec 7, 2018
@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #2409 into develop will decrease coverage by 0.45%.
The diff coverage is 25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2409      +/-   ##
===========================================
- Coverage    26.02%   25.57%   -0.46%     
===========================================
  Files          447      444       -3     
  Lines        16770    16718      -52     
===========================================
- Hits          4365     4276      -89     
- Misses       12405    12442      +37
Impacted Files Coverage Δ
...Controllers/Chat/ChatSections/MessageSection.swift 4.27% <ø> (ø) ⬆️
...cket.Chat/Controllers/Chat/MessagesViewModel.swift 35.02% <ø> (-0.17%) ⬇️
.../Chat/MessagesViewControllerComposerDelegate.swift 0% <ø> (ø) ⬆️
...Chat/Controllers/Chat/MessagesViewController.swift 39.29% <25%> (-2.63%) ⬇️
...odel/AuthSettingsManagerPersistencyExtension.swift 0% <0%> (-61.37%) ⬇️
...Chat/Managers/Socket/Response/SocketHandlers.swift 0% <0%> (-57.5%) ⬇️
Rocket.Chat/Managers/Socket/SocketManager.swift 17.54% <0%> (-24.57%) ⬇️
...Controllers/Auth/ConnectServerViewController.swift 45.54% <0%> (-12.88%) ⬇️
...at/API/Requests/General/LoginServicesRequest.swift 90% <0%> (-10%) ⬇️
Rocket.Chat/Managers/DraftMessageManager.swift 92% <0%> (-8%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09d04c1...a8d9ff8. Read the comment docs.

@rafaelks rafaelks added this to the 3.2.0 milestone Dec 7, 2018
@filipealva filipealva changed the title [WIP][BUG] MessagesViewController keep in memory after closing chat rooms [BUG] MessagesViewController keep in memory after closing chat rooms Dec 7, 2018
//

import RocketChatViewController
import RealmSwift
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤓

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hehe the imports helped me to track leaks related to Realm, so I removed to make sure there was no reference to realm in this file and ended up committing it

@rafaelks rafaelks merged commit 0e10e10 into develop Dec 7, 2018
@rafaelks rafaelks deleted the fix/messages-vc-retain-cycles branch December 7, 2018 21:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants