This repository was archived by the owner on Jun 7, 2020. It is now read-only.
[BUG][RCVC] Long-press & tapping username/avatar is not being handled by cells with attachments #2369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting it up into separated properties
…s attachment cells
houndci-bot
reviewed
Nov 27, 2018
|
|
||
| extension BaseMessageCell: UIGestureRecognizerDelegate { | ||
|
|
||
| func gestureRecognizer(_ gestureRecognizer: UIGestureRecognizer, shouldRequireFailureOf otherGestureRecognizer: UIGestureRecognizer) -> Bool { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 146 characters (line_length)
| } | ||
|
|
||
| if avatarTapGesture == nil { | ||
| let gesture = UITapGestureRecognizer(target: self, action: #selector(handleUsernameTapGestureCell(recognizer:))) |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 124 characters (line_length)
| } | ||
|
|
||
| if usernameTapGesture == nil && username != nil { | ||
| let gesture = UITapGestureRecognizer(target: self, action: #selector(handleUsernameTapGestureCell(recognizer:))) |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 124 characters (line_length)
|
|
||
| func insertGesturesIfNeeded(with username: UILabel?) { | ||
| if longPressGesture == nil { | ||
| let gesture = UILongPressGestureRecognizer(target: self, action: #selector(handleLongPressMessageCell(recognizer:))) |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 128 characters (line_length)
cardoso
approved these changes
Nov 28, 2018
Member
cardoso
left a comment
cardoso
left a comment
There was a problem hiding this comment.
Looks good to me @filipealva 👍
rafaelks
approved these changes
Nov 28, 2018
Contributor
rafaelks
left a comment
rafaelks
left a comment
There was a problem hiding this comment.
Looks way simpler now, thanks @filipealva! 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios
Closes #2364