[NEW] Typing status on the new title view #2314
Conversation
|
|
||
| extension SubscriptionManager { | ||
| static func subscribeTypingEvent(_ subscription: Subscription, completion: @escaping (String?, Bool) -> Void) { | ||
| static func subscribeTypingEvent(_ subscription: UnmanagedSubscription, completion: @escaping (String?, Bool) -> Void) { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 124 characters (line_length)
| } | ||
| } | ||
|
|
||
| private static func websocketUpdatePublicSettings(_ realm: Realm?, _ auth: Auth?, completion: (MessageCompletionObject<AuthSettings>)? = nil) { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 147 characters (line_length)
| completion?(unmanagedSettings) | ||
| } | ||
|
|
||
| static func updatePublicSettings(serverVersion: Version? = nil, apiHost: URL? = nil, _ auth: Auth?, completion: (MessageCompletionObject<AuthSettings>)? = nil) { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 165 characters (line_length)
|
|
||
| extension AuthSettingsManager { | ||
|
|
||
| static func persistPublicSettings(settings: AuthSettings, realm: Realm? = Realm.current, completion: (MessageCompletionObject<AuthSettings>)? = nil) { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 154 characters (line_length)
…feature/typing_status
Codecov Report
@@ Coverage Diff @@
## develop #2314 +/- ##
==========================================
- Coverage 26.11% 25.92% -0.2%
==========================================
Files 438 439 +1
Lines 15969 15998 +29
==========================================
- Hits 4170 4147 -23
- Misses 11799 11851 +52
Continue to review full report at Codecov.
|
@RocketChat/ios
DM
Group, 1 user typing
Group, 2 users typing
Group, 3+ users typing