Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

Conversation

@rafaelks
Copy link
Contributor

@RocketChat/ios

  • Take in consideration changes of urls, attachments and reactions to differentiate a message object;
  • Save user in database on mapping message to make sure user will exist later (fixes the bug where some user's messages would never appear on the screen);
  • Update Firebase app to the correct production one;

Copy link
Member

@cardoso cardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Nov 12, 2018

Codecov Report

Merging #2305 into develop will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #2305     +/-   ##
==========================================
+ Coverage    25.98%   26.18%   +0.2%     
==========================================
  Files          433      433             
  Lines        15876    15885      +9     
==========================================
+ Hits          4125     4160     +35     
+ Misses       11751    11725     -26
Impacted Files Coverage Δ
Rocket.Chat/Models/Message/UnmanagedMessage.swift 9.52% <ø> (ø) ⬆️
...t.Chat/Models/Attachment/UnmanagedAttachment.swift 0% <ø> (ø) ⬆️
...cket.Chat/Models/Mapping/MessageModelMapping.swift 83.14% <100%> (+1.89%) ⬆️
...ontrollers/Base/Main/MainSplitViewController.swift 45% <0%> (-7.5%) ⬇️
...Chat/Controllers/Chat/MessagesViewController.swift 30.3% <0%> (-3.54%) ⬇️
Rocket.Chat/Managers/AppManager.swift 46.3% <0%> (+4.69%) ⬆️
Rocket.Chat/Managers/PushManager.swift 34.48% <0%> (+10.34%) ⬆️
...Chat/Models/Subscription/SubscriptionQueries.swift 100% <0%> (+30%) ⬆️
...anagers/Model/AuthManager/AuthManagerRecover.swift 96.96% <0%> (+60.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea8884d...9f22014. Read the comment docs.

@rafaelks rafaelks merged commit e161b14 into develop Nov 12, 2018
@rafaelks rafaelks deleted the bug/message_update_urls branch November 12, 2018 15:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants