Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

Conversation

@rafaelks
Copy link
Contributor

@rafaelks rafaelks commented Nov 8, 2018

@RocketChat/ios

  • Cache the markdown processed message on the background to be ready when the cell is being presented the first time;
  • Removed unnecessary steps from CocoaPods (there was some duplicated calls on the Build Steps);
  • Improved the usage of delegates on the cells to follow a protocol;

@codecov
Copy link

codecov bot commented Nov 8, 2018

Codecov Report

Merging #2291 into develop will increase coverage by 0.05%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2291      +/-   ##
===========================================
+ Coverage    25.96%   26.02%   +0.05%     
===========================================
  Files          432      432              
  Lines        15857    15836      -21     
===========================================
+ Hits          4118     4121       +3     
+ Misses       11739    11715      -24
Impacted Files Coverage Δ
...t/Views/Chat/New Chat/Cells/ImageMessageCell.swift 0% <ø> (ø) ⬆️
...cket.Chat/Views/Chat/New Chat/Cells/FileCell.swift 0% <ø> (ø) ⬆️
...t/Views/Chat/New Chat/Cells/BasicMessageCell.swift 0% <ø> (ø) ⬆️
...Views/Chat/New Chat/Cells/MessageActionsCell.swift 0% <ø> (ø) ⬆️
...ket.Chat/Views/Chat/New Chat/Cells/QuoteCell.swift 0% <ø> (ø) ⬆️
...Views/Chat/New Chat/Cells/TextAttachmentCell.swift 0% <ø> (ø) ⬆️
...at/Views/Chat/New Chat/Cells/FileMessageCell.swift 0% <ø> (ø) ⬆️
...hat/Views/Chat/New Chat/Cells/MessageURLCell.swift 0% <ø> (ø) ⬆️
Rocket.Chat/Managers/MessageTextCacheManager.swift 83.33% <ø> (ø) ⬆️
...ket.Chat/Views/Chat/New Chat/Cells/ImageCell.swift 0% <ø> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1769158...afefec3. Read the comment docs.

Copy link
Member

@cardoso cardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@filipealva filipealva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking goood 💯

@rafaelks rafaelks merged commit 7db8493 into develop Nov 8, 2018
@rafaelks rafaelks deleted the feature/performance_improvements_messages_list branch November 8, 2018 17:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants