[NEW] Attachments supporting message headers #2254
Conversation
…zingCell on MessagesViewController
| var imageURL: URL? | ||
| let hasText: Bool | ||
|
|
||
| init(identifier: String, title: String?, descriptionText: String?, imageURL: URL?, hasText: Bool, user: UnmanagedUser?, message: UnmanagedMessage?) { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 153 characters (line_length)
| } | ||
|
|
||
| extension BaseTextAttachmentMessageCell: UIGestureRecognizerDelegate { | ||
| func gestureRecognizer(_ gestureRecognizer: UIGestureRecognizer, shouldRequireFailureOf otherGestureRecognizer: UIGestureRecognizer) -> Bool { |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 146 characters (line_length)
| continue | ||
| } | ||
|
|
||
| let attributedValue = NSMutableAttributedString(string: attachmentField.value).transformMarkdown(with: theme) |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 121 characters (line_length)
| // TODO: In case of error, show some error placeholder | ||
| } | ||
| } else { | ||
| // TODO: Load some error placeholder |
There was a problem hiding this comment.
Todo Violation: TODOs should be resolved (Load some error placeholder). (todo)
| ImageManager.loadImage(with: imageURL, into: imageView) { _, _ in | ||
| stopLoadingBlock() | ||
|
|
||
| // TODO: In case of error, show some error placeholder |
There was a problem hiding this comment.
Todo Violation: TODOs should be resolved (In case of error, show some er...). (todo)
| collectionView.register(FileCell.nib, forCellWithReuseIdentifier: FileCell.identifier) | ||
| collectionView.register(FileMessageCell.nib, forCellWithReuseIdentifier: FileMessageCell.identifier) | ||
| collectionView.register(TextAttachmentCell.nib, forCellWithReuseIdentifier: TextAttachmentCell.identifier) | ||
| collectionView.register(TextAttachmentMessageCell.nib, forCellWithReuseIdentifier: TextAttachmentMessageCell.identifier) |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 128 characters (line_length)
Codecov Report
@@ Coverage Diff @@
## feature/integrate-rc-view-controller #2254 +/- ##
=======================================================================
- Coverage 26.43% 26.1% -0.33%
=======================================================================
Files 425 430 +5
Lines 15941 16151 +210
=======================================================================
+ Hits 4214 4217 +3
- Misses 11727 11934 +207
Continue to review full report at Codecov.
|
@RocketChat/ios
Add support to message headers for the following attachments: