This repository was archived by the owner on Jun 7, 2020. It is now read-only.
[NEW] Support editing messages in new composer #2235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cardoso
changed the base branch from
develop
to
feature/integrate-rc-view-controller
Codecov Report
@@ Coverage Diff @@
## feature/integrate-rc-view-controller #2235 +/- ##
========================================================================
+ Coverage 27.55% 27.56% +<.01%
========================================================================
Files 409 411 +2
Lines 15338 15442 +104
========================================================================
+ Hits 4227 4257 +30
- Misses 11111 11185 +74
Continue to review full report at Codecov.
|
rafaelks
reviewed
Oct 3, 2018
| // self.messagesController?.messageToEdit = message | ||
| // TODO: Replace for our own edit text mechanism | ||
| // self.editText(message.text) | ||
| self.messagesController?.editMessage(message) |
rafaelks
approved these changes
Oct 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios
Includes commits from #2233 and #2234 <- need to review & merge those first
BUG:
There's a problem maybe in the DataController. When you try to edit the first message of the day, it either is deleted or crashes. (When exiting and entering the room again it's displayed fine)