This repository was archived by the owner on Jun 7, 2020. It is now read-only.
[IMPROVEMENT] Basic message structure #2204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…messages (using local database messages until we don't have our new DataController)
… so we can do the sizing using the sizeThatFits method after setting the attributed string into it. sizeThatFits has proven to be a lot more precise than boundingRect method that we were using before. This change by itself fixes out issue with messages that were enabling scroll to fully show the message's content
…& few code comments
…he new sizing model
…e error related to the struct's default init
[NEW] Rewrite data controller to messages view model of MessagesViewController
filipealva
changed the title
Contributor
|
Looking nice @filipealva! 👌 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios
There's still things to change on basic message structure but since this PR is becoming too large and blocking new ones let's review it and merge to our base wip branch, that way we can split the next changes into smaller PRs.