Merged
Conversation
added 17 commits
February 3, 2018 13:51
* master: (98 commits) fixed json docs to comply with schema removed destinations on test resources allowed/blocked prefixes per service Voice/SMS/USSD when creating a new link , remove previous link (if any) added 2 new tests for performing multiple link operations fixed ussd tests by adding profile tables provide isolation to unstable dao test ignore unstable test fixed duplicate profile tables profile tables added to all scripts fixed test schemas relocated into specific subresoruce, and sec disabled for schema access fixed bullet list, and code section delete profile associations on removal when delete a profile, delete associations as well corrected assertion added getprofiles json example first draft of Profile API doc fixed getprofiels links fixed default profile provisioning ...
* master: tools relocated to main to allow reuse tools relocated to main to allow reuse Conflicts: restcomm/restcomm.testsuite/src/test/java/org/restcomm/connect/testsuite/http/RestcommAccountsTool.java
jaimecasero
reviewed
Feb 8, 2018
| * @param userIdentityContext | ||
| */ | ||
| protected void filterClosedAccounts(UserIdentityContext userIdentityContext){ | ||
| if(userIdentityContext.getEffectiveAccount() != null && userIdentityContext.getEffectiveAccount().getStatus().equals(Account.Status.CLOSED)){ |
Contributor
There was a problem hiding this comment.
can we do this as part of DAO query(WHERE clause)?
jaimecasero
reviewed
Feb 8, 2018
| import com.sun.jersey.api.client.filter.HTTPBasicAuthFilter; | ||
|
|
||
| @RunWith(Arquillian.class) | ||
| public class RestcommAPIEndpointSecurityTest { |
Contributor
There was a problem hiding this comment.
good idea on creating a separate test to check sec constraints 👍
added 11 commits
February 8, 2018 23:04
* master: smstool relocated for reuse number Utils relocated to main for reusal DialForking test case fixes Fixes in the testsuite for sipunit upgrade Fixes for sipunit upgrade Updated sipunit version to 2.0.3 and mss-arquillian to 1.0.3 Conflicts: restcomm/restcomm.testsuite/src/main/java/org/restcomm/connect/testsuite/provisioning/number/vi/RestcommIncomingPhoneNumberTool.java
added 2 commits
February 10, 2018 16:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.