Add the_password_form_redirect_url filter to get_the_password_form().…#1
Open
Add the_password_form_redirect_url filter to get_the_password_form().…#1
Conversation
Add a `@since` annotation to `add_theme_support()` to deprecate `html5` feature's `script` and `style` arguments. Developed in WordPress#11061. Follow-up to [61415]. Props jonsurrell, westonruter. Fixes #64442. git-svn-id: https://develop.svn.wordpress.org/trunk@61791 602fd350-edb4-49c9-b593-d223f7449a82
Developed in WordPress#11076. Props jonsurrell, westonruter. See #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61792 602fd350-edb4-49c9-b593-d223f7449a82
Add `@ignore` annotations to internal HTML API methods and classes to exclude them from generated documentation. The HTML API relies heavily on internal methods and classes and they create a lot of noise in documentation. Developed in WordPress#11078. Props jonsurrell, westonruter. See #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61793 602fd350-edb4-49c9-b593-d223f7449a82
Omit these files which offer little value since the VIPS library is primarily inlined WASM. Saves ~30MB total from the build output. Props swissspidy, westonruter, adamsilverstein, berislav.grgicak, knutsp. Fixes: #64734. git-svn-id: https://develop.svn.wordpress.org/trunk@61794 602fd350-edb4-49c9-b593-d223f7449a82
Make `WP_AI_Client_Ability_Function_Resolver` non-static and require specifying the allowed abilities list in the constructor. This hardens security by ensuring that only explicitly specified abilities can be executed, preventing potential vulnerabilities such as prompt injection from triggering arbitrary abilities. The constructor accepts either `WP_Ability` objects or ability name strings. If an ability is not in the allowed list, an error response with code `ability_not_allowed` is returned. Developed in WordPress#11103. Upstream: WordPress/wp-ai-client#61. Props felixarntz, gziolo, JasonTheAdams, dkotter, johnbillion. Fixes #64769. git-svn-id: https://develop.svn.wordpress.org/trunk@61795 602fd350-edb4-49c9-b593-d223f7449a82
The method should only apply to special "atomic" HTML tags like `SCRIPT` or `TEXTAREA`. `::set_modifiable_text()` should not apply to tags with the same name in other namespaces. Developed in WordPress#11083. Props jonsurrell, dmsnell, westonruter. Fixes #64751. git-svn-id: https://develop.svn.wordpress.org/trunk@61796 602fd350-edb4-49c9-b593-d223f7449a82
Developed in WordPress#11126 Follow up to r40628. Props soean, swissspidy, ocean90, sajib1223, manhar. Fixes #64784. git-svn-id: https://develop.svn.wordpress.org/trunk@61797 602fd350-edb4-49c9-b593-d223f7449a82
Ensure that the black background covers the entire width of the header on large screens, ensure that the dismiss button appears on small screens. Props peterwilsoncc, ramonopoly, huzaifaalmesbah, marc4, shailu25, ocean90, krokodok, karinchristen, hubersen, stefanvelthuys, joedolson. Fixes #64741. git-svn-id: https://develop.svn.wordpress.org/trunk@61798 602fd350-edb4-49c9-b593-d223f7449a82
Following [61555], the post type icons were missing from the At a Glance dashboard widget. Restore the post type class omitted from the previous commit. Props ocean90, krokodok, karinchristen, hubersen, stefanvelthuys, ozgursar, sabernhardt, joedolson. Fixes #43084. git-svn-id: https://develop.svn.wordpress.org/trunk@61799 602fd350-edb4-49c9-b593-d223f7449a82
…inting at initialization. * Refactor how CodeMirror is initialized so that the full settings are provided up-front. This avoids the linting from being applied twice at initialization, the first time with an incorrect configuration. * Add initial TypeScript configuration for core with `npm run typecheck:js`. * Add comprehensive types for code editor files: `code-editor.js`, `javascript-lint.js`, and `htmlhint-kses.js`. * Move code editor scripts from `src/js/_enqueues/vendor/codemirror/` to `src/js/_enqueues/lib/codemirror/`. The CodeMirror library is sourced from the npm package as of r61539. * Remove (deprecated) `esprima.js` from being committed to SVN since in r61539 it was switched to using the npm package as its source. * Move `fakejshint.js` to `src/js/_enqueues/deprecated`. Developed in WordPress#10900 Follow up to r61611, r61539. Props westonruter, jonsurrell, justlevine. See #64662, #48456. Fixes #64661. git-svn-id: https://develop.svn.wordpress.org/trunk@61800 602fd350-edb4-49c9-b593-d223f7449a82
… badges. Props huzaifaalmesbah, niravsherasiya7707, noruzzaman. Fixes #64772. git-svn-id: https://develop.svn.wordpress.org/trunk@61807 602fd350-edb4-49c9-b593-d223f7449a82
…tream. Third-party paths are also re-sorted in the PHPStan config. Developed in WordPress#11150 Follow up to r61776, r61712, r61699. Props justlevine, flixos90, westonruter. See #64591, #61175. git-svn-id: https://develop.svn.wordpress.org/trunk@61808 602fd350-edb4-49c9-b593-d223f7449a82
Fix an issue where sideloaded images with a ‘-scaled’ suffix would respond with an error. When users upload a very large image in the editor, the client-side media processing sideloads a scaled version of that image with a ‘-scaled’ suffix. Props adamsilverstein, huzaifaalmesbah, westonruter. Fixes #64737. git-svn-id: https://develop.svn.wordpress.org/trunk@61809 602fd350-edb4-49c9-b593-d223f7449a82
Replaces `_wp_connectors_get_provider_settings()` with `_wp_connectors_get_connector_settings()` that returns a richer structure keyed by connector ID, including name, description, type, plugin slug, and an authentication sub-object (method, credentials_url, setting_name). The new function merges hardcoded defaults for featured providers (Anthropic, Google, OpenAI) with metadata from the WP AI Client registry, allowing dynamically registered providers to appear alongside built-in ones. Providers are sorted alphabetically with `ksort()`. Additionally: * Renames `_wp_connectors_is_api_key_valid()` to `_wp_connectors_is_ai_api_key_valid()`. * Adds `_wp_connectors_get_connector_script_module_data()` to expose connector settings to the `connectors-wp-admin` script module. * Includes plugin slug data for featured connectors to support install/activate UI. * Removes redundant `class_exists` checks for `AiClient`. * Runs `init` hooks at priority 20 so provider plugins registered at default priority are available. * Unhooks connector registration during tests to prevent duplicate registrations. Synced from WordPress/gutenberg#76014. Developed in WordPress#11080. Follow-up to [61749]. Props gziolo, jorgefilipecosta, justlevine, flixos90, ellatrix. Fixes #64730. git-svn-id: https://develop.svn.wordpress.org/trunk@61824 602fd350-edb4-49c9-b593-d223f7449a82
Changes the Connectors screen URL from a query parameter page to a direct file, following the Settings menu naming convention used by other settings pages (`options-general.php`, `options-writing.php`, etc.). * Adds `src/wp-admin/options-connectors.php` as a direct admin screen file. * Adds a static submenu entry in `menu.php` at position 12 (after General). * Removes `_wp_connectors_add_settings_menu_item()` and its `admin_menu` hook from `connectors.php`. * Updates the `script_module_data` filter from `connectors-wp-admin` to `options-connectors-wp-admin`. Synced from WordPress/gutenberg#76142. Developed in WordPress#11157. Follow-up to [61749], [61824]. See #64730. Props jorgefilipecosta, gziolo. Fixes #64790. git-svn-id: https://develop.svn.wordpress.org/trunk@61825 602fd350-edb4-49c9-b593-d223f7449a82
Set the `/blog` prefix to place the `/` correctly in RTL languages. Adjust the layout to prevent awkward wrapping in all languages on smaller viewports. Props sabernhardt, rachid84, johnbillion, SergeyBiryukov, costdev, joedolson, afercia, ryokuhi, oglekler, sirlouen, audrasjb, huzaifaalmesbah. Fixes #58722. See #47755. git-svn-id: https://develop.svn.wordpress.org/trunk@61826 602fd350-edb4-49c9-b593-d223f7449a82
Change inputs in the bulk and quick edit to use compact sizing. Props mohitbsf, sabernhardt, mukesh27, juanmaguitar, fabiankaegy, shailu25, joedolson. Fixes #64685. git-svn-id: https://develop.svn.wordpress.org/trunk@61827 602fd350-edb4-49c9-b593-d223f7449a82
The option name is changed since the previous option name set a default value during database initialization. A default is no longer needed since the default is false. Developed in: WordPress#11159. Fixes #64622. Props czarate. git-svn-id: https://develop.svn.wordpress.org/trunk@61828 602fd350-edb4-49c9-b593-d223f7449a82
Connector API keys were visible in plain text on `wp-admin/options.php` because it queries the database directly, bypassing the `get_option()` filter that normally masks these values. This adds masking for options matching the `connectors_*_api_key` pattern using the existing `_wp_connectors_mask_api_key()` function, and disables editing from this screen. Props jorgefilipecosta, gziolo, ocean90. Fixes #64793. git-svn-id: https://develop.svn.wordpress.org/trunk@61829 602fd350-edb4-49c9-b593-d223f7449a82
…flow. This introduces a new GitHub Action workflow for JavaScript type checking, mirroring the implementation for PHPStan in #61175. It also adds a `typecheck:js` Grunt task and includes it in the `precommit:js` task list. Only files related to the code editor are initially checked with TypeScript, with the expectation that additional files will be added to the `files` list in `tsconfig.json` as a part of ongoing maintenance work, for example #64238 and #64226. Developed in WordPress#11131 Follow up to r61699, r61800, r61539. Props westonruter, jonsurrell. See #61175, #64661, #48456. Fixes #64662. git-svn-id: https://develop.svn.wordpress.org/trunk@61830 602fd350-edb4-49c9-b593-d223f7449a82
The background behind theme actions for the active theme was still visible when no actions were available, such as with a disabled customizer. Removing the background on this container improves the design of the active theme card by simplifying the layout and prevents the appearance of an error if no actions are available. Remove background and inset box shadow for the `.theme.active .theme-actions` container on the active theme. Props awetz583, huzaifaalmesbah, noruzzaman, shailu25, joedolson. Fixes #64720. git-svn-id: https://develop.svn.wordpress.org/trunk@61831 602fd350-edb4-49c9-b593-d223f7449a82
Props ocean90, niravsherasiya7707, noruzzaman, manishxdp, huzaifaalmesbah, SergeyBiryukov. Fixes #64788. git-svn-id: https://develop.svn.wordpress.org/trunk@61832 602fd350-edb4-49c9-b593-d223f7449a82
This reverts the real time collaboration option name back to `wp_enable_real_time_collaboration` to avoid the need to turn on a checkbox in order to turn off the feature. This is to reduce the cognitive load on both users and developers of an on is off paradigm. To ensure Real Time Collaboration is enabled prior to the upgrade routine running on multi-site installs, the option default is filtered on the `default_option_wp_enable_real_time_collaboration` hook to enable the option by default. Developed in: WordPress#11161 Follow up to r61828. Props peterwilsoncc, czarate, sergeybiryukov. Fixes #64622. git-svn-id: https://develop.svn.wordpress.org/trunk@61833 602fd350-edb4-49c9-b593-d223f7449a82
Update the `event-none` class in the WordPress Events and News widget to use the new color palette. Props huzaifaalmesbah, ocean90, noruzzaman, hmbashar, mukesh27, shailu25, joedolson. Fixes #64756. git-svn-id: https://develop.svn.wordpress.org/trunk@61834 602fd350-edb4-49c9-b593-d223f7449a82
Use the compact button size for the customizer theme feature filter trigger. Props joedolson, huzaifaalmesbah, shailu25, noruzzaman. Fixes #64755. git-svn-id: https://develop.svn.wordpress.org/trunk@61835 602fd350-edb4-49c9-b593-d223f7449a82
The GitHub Actions workflow responsible for running the PHPUnit test suite is frequently encountering the default `timeout-minutes` value of `20` since the changes in [61438]. The result is that the workflow is consistently unable to finish running and ends up being cancelled. This bumps the default value to `40` until the overall speed of the build script can be improved. See #64225, #64227, #64393. git-svn-id: https://develop.svn.wordpress.org/trunk@61836 602fd350-edb4-49c9-b593-d223f7449a82
…kflows and remove unused Dependabot exclusion. Developed in WordPress#11163 Follow up to r61830, r61699, r61050, r61049. Props desrosj, westonruter. See #61175. Fixes #64662. git-svn-id: https://develop.svn.wordpress.org/trunk@61837 602fd350-edb4-49c9-b593-d223f7449a82
…update. Using the built-in HTTP polling sync server, awareness state is accepted and stored after the user is authorized. This state is keyed against their sync client ID, which is randomly generated. However, nothing prevents a user from spoofing another client's client ID, which is discoverable by inspecting network responses. By replaying a sync request with a different client ID, they could temporarily overwrite another client's awareness state. This change prevents this spoofing by storing and checking the user's WordPress user ID to ensure it matches the initial update. Developed in: WordPress#11120. Syncs: WordPress/gutenberg#76056. Fixes #64782. Props czarate. git-svn-id: https://develop.svn.wordpress.org/trunk@61838 602fd350-edb4-49c9-b593-d223f7449a82
When a user sends a stale compaction update to WP_HTTP_Polling_Sync_Server, it falls through the switch statement and results in a rest_invalid_update_type error (bad request). This generally has no ill effect since the compaction request is rescinded on the next polling cycle, but it could cause confusion for users who are monitoring client-side requests or server logs. To fix, replace the break after the $has_newer_compaction check with return true so that the stale compaction is silently discarded instead of falling through. Covered by unit test. Developed in: WordPress#11118. Syncs: WordPress/gutenberg#76060. Fixes #64781. Props czarate, mindctrl. git-svn-id: https://develop.svn.wordpress.org/trunk@61839 602fd350-edb4-49c9-b593-d223f7449a82
Updates the disabled state colors for the primary and secondary buttons to align with the WordPress Design System. Props hbhalodia, huzaifaalmesbah, Joen, mciampini, ozgursar, wildworks. Fixes #64797. git-svn-id: https://develop.svn.wordpress.org/trunk@61840 602fd350-edb4-49c9-b593-d223f7449a82
…from `init` to `wp_default_styles`. This ensures the filters to opt in to loading separate block styles on demand are added at the moment `WP_Styles` is constructed. This accounts for styles being registered at the `init` action before `register_core_block_style_handles()` runs at priority 9. Without this, the `wp-block-library` stylesheet may get registered with the full combined block styles as `style.css` instead of just `common.css`, due to `wp_should_load_block_assets_on_demand()` still returning false. The `wp_default_styles` action still runs during `init`. Developed in WordPress#11232 Follow-up to r61008. Props westonruter, adamsilverstein. See #64099. Fixes #64846. git-svn-id: https://develop.svn.wordpress.org/trunk@61981 602fd350-edb4-49c9-b593-d223f7449a82
Introduce a `POST /wp/v2/media/{id}/finalize` REST API endpoint that re-triggers the `wp_generate_attachment_metadata` filter with context `'update'` after client-side media processing completes. This ensures server-side plugins (watermarking, CDN sync, custom sizes, etc.) can post-process attachments when client-side processing is active.
The endpoint reuses `edit_media_item_permissions_check` for authorization and is only registered when `wp_is_client_side_media_processing_enabled()` returns true.
See WordPress/gutenberg#74913.
See WordPress/gutenberg#74358.
Props adamsilverstein, westonruter, mukesh27, divyeshpatel01.
Fixes #64804.
git-svn-id: https://develop.svn.wordpress.org/trunk@61982 602fd350-edb4-49c9-b593-d223f7449a82
Remove `_wp_connectors_get_connector_settings()` and inline `ksort()` into `_wp_connectors_get_connector_script_module_data()`. Expand `@return` and `@phpstan-return` array shapes for `wp_get_connector()` and `wp_get_connectors()`. Make `logo_url` and `credentials_url` truly optional. Rename test class to `wpGetConnectors`. Developed in WordPress#11227. Follow-up to [61943]. Props gziolo, westonruter. Fixes #64791. git-svn-id: https://develop.svn.wordpress.org/trunk@61983 602fd350-edb4-49c9-b593-d223f7449a82
Enable client-side media processing in the three `test_finalize_item*` tests so the `/finalize` route is registered before dispatching requests. Without this, the route does not exist and all assertions fail with `rest_no_route`. Extracts the repeated filter-and-reinitialize pattern into a shared `enable_client_side_media_processing()` helper, used by both the sideload and finalize tests. Follow-up to [61982]. git-svn-id: https://develop.svn.wordpress.org/trunk@61984 602fd350-edb4-49c9-b593-d223f7449a82
…masking. Add `_wp_connectors_get_api_key_source()` to detect whether an API key is configured via environment variable, PHP constant, or database. The UI uses this to show the key source and hide "Remove and replace" for externally configured keys. Replace `_wp_connectors_validate_keys_in_rest()` and `_wp_connectors_get_real_api_key()` with a single `rest_post_dispatch` handler, `_wp_connectors_rest_settings_dispatch()`, that masks keys in all `/wp/v2/settings` responses and validates on POST/PUT, reverting invalid keys. Simplify `_wp_register_default_connector_settings()` by replacing the closure-based `sanitize_callback` and `option_` mask filter with plain `sanitize_text_field`, since masking is now handled at the REST layer. Enrich `_wp_connectors_get_connector_script_module_data()` to expose `keySource`, `isConnected`, `logoUrl`, and plugin `isInstalled` / `isActivated` status to the admin screen. Update `_wp_connectors_pass_default_keys_to_ai_client()` to skip keys sourced from environment variables or constants and read the database directly via `get_option()`. Set `_wp_connectors_init` priority to 15 so the registry is ready before settings are registered at priority 20. Backports WordPress/gutenberg#76266. Backports WordPress/gutenberg#76327. Props jorgefilipecosta, gziolo, swissspidy, flixos90. Fixes #64819. git-svn-id: https://develop.svn.wordpress.org/trunk@61985 602fd350-edb4-49c9-b593-d223f7449a82
In performance tests, editing large documents in the site-editor suite (loading large-post.html) can cause performance tests in the site editor to time out with memory errors. Developed in: WordPress#11181. Props alecgeatches, mukesh27. See #64622. git-svn-id: https://develop.svn.wordpress.org/trunk@61986 602fd350-edb4-49c9-b593-d223f7449a82
Use `rest_is_field_included()` instead of `in_array()` for `content`, `title`, `excerpt`, and `guid` fields in `WP_REST_Revisions_Controller`. This lets clients request specific sub-fields (e.g. `_fields=content.raw`) and skip expensive `the_content` rendering. The [REST API `_fields` documentation](https://developer.wordpress.org/rest-api/using-the-rest-api/global-parameters/#_fields) states that nested fields are supported using dot notation. However, the revisions controller uses `in_array()` which doesn't match nested keys like `content.raw`. Developed in: WordPress#11230. Props ellatrix, andrewserong, mukeshpanchal27. Fixes #64844. git-svn-id: https://develop.svn.wordpress.org/trunk@61987 602fd350-edb4-49c9-b593-d223f7449a82
This updates the pinned hash from the `gutenberg` from `9b8144036fa5faf75de43d4502ff9809fcf689ad` to `8c78d87453509661a9f28f978ba2c242d515563b`. The following changes are included: - Navigation Editor: Allow any blocks to be inserted by gating contentOnly insertion rules to section blocks (WordPress/gutenberg#76189) - Add `fetchpriority=low` to `IMG` tags in collapsed Details blocks (WordPress/gutenberg#76269) - Connectors: Add logo URL support for custom AI providers (WordPress/gutenberg#76190) - Cover Block: Add a playlist parameter to loop YouTube background videos. (WordPress/gutenberg#76004) - Connectors: Memoize getConnectors selector (WordPress/gutenberg#76339) - HTML Block: Fix broken layout (WordPress/gutenberg#76278) - Tests: Skip connector logo URL tests when AI Client is unavailable (WordPress/gutenberg#76343) - Navigation Overlay: Explicitly set fetchpriority for images (WordPress/gutenberg#76208) - Connectors: Show API key source for env vars and wp-config constants (WordPress/gutenberg#76355) - Connectors: Move API key validation and masking to REST dispatch level (WordPress/gutenberg#76327) - Connectors: Replace apiFetch with core-data store selectors (WordPress/gutenberg#76333) - Do not sync local attributes (WordPress/gutenberg#76267) - Add `fetchpriority=low` to `IMG` tags in collapsed Accordion Item blocks (WordPress/gutenberg#76336) - Implement disconnection debounce after initial connection (WordPress/gutenberg#76114) - Allow Post Content to be edited when 'Show template' is active and Post content is nested in a Template Part (WordPress/gutenberg#76305) - Fix: Document Bar: Back button flickers (WordPress/gutenberg#76320) - RTC: Move event hooks from editor to core-data (WordPress/gutenberg#76358) - fix(navigation): prevent right-justified submenu overflow in custom overlays (WordPress/gutenberg#76360) - Connectors: Add connectors registry for extensibility (WordPress/gutenberg#76364) - Connectors: Add empty state when no connectors are registered (WordPress/gutenberg#76375) - Temp: Disable RTC in the site editor (WordPress/gutenberg#76223) - Connectors: Add AI Experiments plugin callout with install/activate functionality (WordPress/gutenberg#76379) - Editor: Polish real-time collaboration presence UI and move Avatar to editor package (WordPress/gutenberg#75652) (WordPress/gutenberg#76365) - RTC: Add collaborator selection highlighting in rich text (WordPress/gutenberg#76107) - Sync changes from `wp_enqueue_global_styles()` to Gutenberg override (WordPress/gutenberg#76127) - [RTC] Fix performance regression on post save (WordPress/gutenberg#76370) - Media: Enable AVIF support for client-side uploads (WordPress/gutenberg#76371) - Connectors: Move plugin status computation to script module data (WordPress/gutenberg#76409) - Revisions: Skip rendered fields in REST API responses (WordPress/gutenberg#76347) - E2E Tests: Add connector setup flow tests with test AI provider (WordPress/gutenberg#76433) - RTC: Place sync connection modal in front of popover (WordPress/gutenberg#76431) - Connectors: Sync PHP code with WordPress Core (WordPress/gutenberg#76443) - Editor: Show own presence in collaborative editing sessions (WordPress/gutenberg#76413) (WordPress/gutenberg#76445) A full list of changes can be found on GitHub: https://github.com/WordPress/gutenberg/compare/9b8144036fa5faf75de43d4502ff9809fcf689ad…8c78d87453509661a9f28f978ba2c242d515563b. Log created with: git log --reverse --format="- %s" 9b8144036fa5faf75de43d4502ff9809fcf689ad..8c78d87453509661a9f28f978ba2c242d515563b | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy See #64595. git-svn-id: https://develop.svn.wordpress.org/trunk@61988 602fd350-edb4-49c9-b593-d223f7449a82
…sign. Developed in WordPress#11026 Props juanfra, westonruter, jeffpaul, mukesh27, audrasjb, joedolson, dd32, davidbaumwald, fabiankaegy, huzaifaalmesbah, Joen, butterflymedia, noruzzaman, karmatosed, ozgursar, fcoveram, tusharaddweb, darshitrajyaguru97. See #64308. Fixes #64708. git-svn-id: https://develop.svn.wordpress.org/trunk@61989 602fd350-edb4-49c9-b593-d223f7449a82
git-svn-id: https://develop.svn.wordpress.org/trunk@61990 602fd350-edb4-49c9-b593-d223f7449a82
git-svn-id: https://develop.svn.wordpress.org/trunk@61991 602fd350-edb4-49c9-b593-d223f7449a82
This commit simply removes a `$network_exists` variable (introduced in r41384) that was never used. Props mukesh27, Soean. Fixes #64851. git-svn-id: https://develop.svn.wordpress.org/trunk@61992 602fd350-edb4-49c9-b593-d223f7449a82
Developed in WordPress#11205 Props apermo, mukesh27. See #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61994 602fd350-edb4-49c9-b593-d223f7449a82
Update incorrect uses of `null` as a single parameter type to be `mixed` instead, largely targeting `$deprecated` variable names. Pipe `|` a few `null`s with other valid types where appropriate. Add a missing empty new-line between the `_deprecated_file()` and `_deprecated_argument()` functions. See #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61995 602fd350-edb4-49c9-b593-d223f7449a82
When an attachment is used by multiple posts, it could be included in `_embed` for a published post even if its `post_parent` is a draft. This commit avoids embedding attachments that are not viewable in this context. Props bor0. Fixes #64183. git-svn-id: https://develop.svn.wordpress.org/trunk@61996 602fd350-edb4-49c9-b593-d223f7449a82
…ded with a `null` parent. Developed in WordPress#11055 Props sky_76, westonruter, ozgursar, sabernhardt. Fixes #64728. git-svn-id: https://develop.svn.wordpress.org/trunk@61997 602fd350-edb4-49c9-b593-d223f7449a82
The `rest_revision_query` filter in `WP_REST_Revisions_Controller::get_items()` carried a cross-reference comment claiming it was documented in the posts controller. This was incorrect, as the posts controller documents `rest_{$this->post_type}_query` — a dynamic hook that fires only for post types managed by `WP_REST_Posts_Controller`.
`WP_REST_Revisions_Controller` extends `WP_REST_Controller` directly (not the posts controller), so the dynamic hook never fires for revisions. `rest_revision_query` is a standalone hook and has never had its own PHPDoc block.
Follow-up to [43584].
Props apermo, mukesh27, SergeyBiryukov.
See #64224.
git-svn-id: https://develop.svn.wordpress.org/trunk@61998 602fd350-edb4-49c9-b593-d223f7449a82
Replace `@group rest-api` with `@group restapi` to unify the tests under the one group name, chosen on the basis that majority rules. Follow up to r61045, r61032. See #64225. git-svn-id: https://develop.svn.wordpress.org/trunk@61999 602fd350-edb4-49c9-b593-d223f7449a82
…it_link()` which is being passed in some templates. This addresses `arguments.count` errors identified by PHPStan at rule level 1. Developed in WordPress#11242 Follow-up to WordPress/twentyseventeen commits: [WordPress/twentyseventeen@1afb73c 1afb73c], [WordPress/twentyseventeen@7dd3025#diff-88ec0e9d51b04231a448a06c40ced21810e85361ced9481a9248f1075226c6aa 7dd3025], [https://github.com/WordPress/twentyseventeen/blob/69482880b4ae2ec145f60df417423665581a5653/inc/template-tags.php#L104-L128 6948288]. Props sabernhardt, westonruter. See #64680. Fixes #64825. git-svn-id: https://develop.svn.wordpress.org/trunk@62000 602fd350-edb4-49c9-b593-d223f7449a82
This improves how the built Gutenberg asset is retrieved from the GitHub Container Registry to avoid situations where the download fails when the directory already exists. - The related `postinstall` command has changed from `gutenberg:download` to `gutenberg:verify`. - The `--force` option has been removed. `gutenberg:download` will now download a fresh copy every time it's run. - The `gutenberg:verify` script is now the preferred entry point for managing the files within the `gutenberg` directory. It will only trigger a downoad if the hashes do not match, or the folder is missing entirely. Follow up to [61438], [61873], [61874]. Props bernhard-reiter. See #64393. git-svn-id: https://develop.svn.wordpress.org/trunk@62021 602fd350-edb4-49c9-b593-d223f7449a82
In MySQL 8.0, the default authentication plugin changed from `mysql_native_password` to `caching_sha2_password`, which is not available in PHP 7.3 and earlier. The installation testing workflow currently accounts for this, but only for PHP 7.2 & 7.3. It also does not account for a change in MySQL 8.4 which changed the related flag for controlling this from `--default-authentication-plugin` to `--authentication-policy`. This adjusts the flags and surrounding conditions to ensure the correct ones are passed for the right combinations. Props johnbillion. See #64225, #64227. git-svn-id: https://develop.svn.wordpress.org/trunk@62022 602fd350-edb4-49c9-b593-d223f7449a82
This excludes MySQL 9.5 jobs for the installation testing workflow. Only the most recent innovation release of MySQL should be tested. Follow up to [61875]. See #64225, #64227. git-svn-id: https://develop.svn.wordpress.org/trunk@62023 602fd350-edb4-49c9-b593-d223f7449a82
…date_link()`. Follow-up to [8758], [15564]. Props marian1. Fixes #64764. git-svn-id: https://develop.svn.wordpress.org/trunk@62024 602fd350-edb4-49c9-b593-d223f7449a82
This changeset introduces the `wp_admin_bar_add_color_scheme_to_front_end()` which is hooked on `admin_bar_init` in order to use the CSS from admin color schemes on the admin bar on front-end, as inline styles. Props sabernhardt, huzaifaalmesbah, audrasjb, johnbillion, noruzzaman, JeffPaul, joedolson, huzaifaalmesbah, amesplant, r1k0, shailu25. Fixes #64762. git-svn-id: https://develop.svn.wordpress.org/trunk@62025 602fd350-edb4-49c9-b593-d223f7449a82
This changeset prevents users from removing their own role when bulk editing user roles. Props jomonthomaslobo1, johnbillion, hugod, audrasjb, shailu25, rishavdutta, rollybueno. Fixes #63068. git-svn-id: https://develop.svn.wordpress.org/trunk@62026 602fd350-edb4-49c9-b593-d223f7449a82
Regnalf
force-pushed
the
feature/64785-password-form-redirect
branch
from
c3f2562 to
747cdb6
Compare
Regnalf
force-pushed
the
feature/64785-password-form-redirect
branch
from
747cdb6 to
fbea1a3
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Regnalf
pushed a commit
that referenced
this pull request
Apr 7, 2026
…om `previous_posts()`. The `esc_url()` function expects to a string for `$url` parameter. There is no input validation within that function. The function contains a `ltrim()` which also expects a string. Passing `null` to this parameter results in `Deprecated: ltrim(): Passing null to parameter #1 ($string) of type string is deprecated` notice on PHP 8.1+. Tracing the stack back, a `null` is being passed to it within `previous_posts()` when `get_previous_posts_page_link()` returns `null` (it can return a string or `null`). On PHP 7.0 to PHP 8.x, an empty string is returned from `esc_url()` when `null` is passed to it. The change in this changeset avoids the deprecation notice by not invoking `esc_url()` when `get_previous_posts_page_link()` returns `null` and instead sets the `$output` to an empty string, thus maintaining the same behavior as before (minus the deprecation notice). Adds a test to validate an empty string is returned and the absence of the deprecation (when running on PHP 8.1+). Follow-up to [9632], [11383], [56740]. Props dd32, alexodiy. Fixes #64864. git-svn-id: https://develop.svn.wordpress.org/trunk@62034 602fd350-edb4-49c9-b593-d223f7449a82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new filter
the_password_form_redirect_urlinget_the_password_form()to allow developers to customize the redirect destination after a password has been entered.Currently, this is hardcoded to the post's permalink. In scenarios like "Public Preview Links" or headless setups, the standard permalink might not be the correct return-to URL. This filter provides a clean way to modify the URL without parsing the entire HTML form.
Trac ticket: https://core.trac.wordpress.org/ticket/64785