Skip to content

Fixing crash in the custom Split function (iOS 15 and earlier) #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Recouse merged 2 commits into from
Feb 28, 2025
Merged

Fixing crash in the custom Split function (iOS 15 and earlier) #26

Recouse merged 2 commits into from
Feb 28, 2025

Conversation

@maximbilan
Copy link

@maximbilan maximbilan commented Feb 19, 2025

@maximbilan maximbilan requested a review from Recouse as a code owner February 19, 2025 09:11
@maximbilan maximbilan mentioned this pull request Feb 19, 2025
Closed
@Recouse
Copy link
Owner

Recouse commented Feb 19, 2025

Since there are no tests and the extension is private, I'll test it manually and consider adding tests for iOS 15 in the CI.
If you have any suggestions, feel free to modify this PR or create a new one.

@maximbilan
Copy link
Author

maximbilan commented Feb 19, 2025

Since there are no tests and the extension is private, I'll test it manually and consider adding tests for iOS 15 in the CI. If you have any suggestions, feel free to modify this PR or create a new one.

Thank you!

@Recouse Recouse merged commit d3ecd3b into Recouse:main Feb 28, 2025
3 checks passed
@Recouse Recouse mentioned this pull request Mar 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Recouse Recouse Recouse approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ServerEventParser crashes on iOS 15

2 participants

@maximbilan @Recouse