Properly remove forbidden species from edge #1556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjohnson541
added
Type: Risk of Error
Status: Ready for Review
Codecov Report
@@ Coverage Diff @@
## master #1556 +/- ##
==========================================
+ Coverage 41.85% 41.86% +<.01%
==========================================
Files 165 165
Lines 28014 28008 -6
Branches 5716 5713 -3
==========================================
Hits 11726 11726
+ Misses 15500 15494 -6
Partials 788 788
Continue to review full report at Codecov.
|
amarkpayne
approved these changes
Feb 24, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that occurs when forbidden species are removed from the edge. Currently this is done manually not using removeSpeciesFromEdge which leaves the species and reactions still in memory in more obscure locations leading to key errors later on. This PR switches to using removeSpeciesFromEdge avoiding these problems.