Fix #7354, Implementing NSE in cube #7603
Open
+108
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisyphuswastaken
requested review from
MichaelChirico and
jangorecki
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7603 +/- ##
==========================================
- Coverage 99.00% 98.99% -0.01%
==========================================
Files 87 87
Lines 16893 16935 +42
==========================================
+ Hits 16725 16765 +40
- Misses 168 170 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
jangorecki
reviewed
Jan 19, 2026
| # redirect to workhorse function | ||
| jj = substitute(j) | ||
| groupingsets.data.table(x, by=by, sets=sets, .SDcols=.SDcols, id=id, jj=jj, label=label, enclos = parent.frame()) | ||
| # input data type basic validation |
Member
There was a problem hiding this comment.
Changes in those lines looks to be unrelated to this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pertains to issue #7354.
Changes implemented:
This PR continues work from Implementing NSE in cube #7540 and and Implementing NSE in cube #7543.