This repository was archived by the owner on Feb 5, 2019. It is now read-only.
Fixes bug where leaf controllers recieve nil messages#42
Open
mileswu wants to merge 1 commit intoRISCfuture:masterfrom
Open
Fixes bug where leaf controllers recieve nil messages#42mileswu wants to merge 1 commit intoRISCfuture:masterfrom
mileswu wants to merge 1 commit intoRISCfuture:masterfrom
Conversation
Bug was caused in commit ee38e8c (Manual style changes) Message would be set as nil when there was a message, as "stuff".presence => "stuff". Likewise if there was no message, msg would be kept as "" as "".presence => nil.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug was caused in commit ee38e8c (Manual style changes)
Message would be set as nil when there was a message, as
"stuff".presence => "stuff". Likewise if there was no message,
msg would be kept as "" as "".presence => nil.