[#95] Upgrade prometheus-operator monitoring to v0.55.1#96
Merged
tchughesiv merged 1 commit intoRHsyseng:nextfrom May 2, 2022
Merged
[#95] Upgrade prometheus-operator monitoring to v0.55.1#96tchughesiv merged 1 commit intoRHsyseng:nextfrom
tchughesiv merged 1 commit intoRHsyseng:nextfrom
Conversation
Collaborator
|
hey @brusdev seems that vet's identified an issue around a missing dependency declaration or similar, could you PTAL? Thanks!! |
brusdev
force-pushed
the
upgrade_monitoring_v0.55.1
branch
from
408802b to
4d1a1e6
Compare
Contributor
Author
|
@jeremyary this issue was fixed in go 1.17, see kubernetes-sigs/controller-tools#643 |
tchughesiv
requested changes
Apr 7, 2022
Member
tchughesiv
left a comment
tchughesiv
left a comment
There was a problem hiding this comment.
please rebase on our next branch and change the PR to that branch
brusdev
force-pushed
the
upgrade_monitoring_v0.55.1
branch
from
4d1a1e6 to
bfde175
Compare
Contributor
Author
|
@jeremyary @tchughesiv I rebased on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.