REF and TEST: rank_size in inequality.py#551
Merged
mmcky merged 1 commit intoQuantEcon:masterfrom Jun 29, 2020
Merged
Conversation
|
Hello @bktaha! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
Contributor
|
thanks @bktaha. As @jstac mentions in the issue we will need to coordinate updates for: https://github.com/QuantEcon/lecture-python source/rst/kesten_processes.rst: qe.rank_size_plot(data, ax, c=0.01)
source/rst/wealth_dynamics.rst:If you like, you can use the function ``rank_size_plot`` from the ``quantecon`` library (documentation `here <https://quanteconpy.readthedocs.io/en/latest/tools/inequality.html#quantecon.inequality.rank_size_plot>`__).
source/rst/wealth_dynamics.rst: qe.rank_size_plot(ψ_star, ax, c=0.001)
source/rst/heavy_tails.rst:If you like you can use the function ``qe.rank_size_plot`` from the ``quantecon`` library to generate the plots.
source/rst/heavy_tails.rst: qe.rank_size_plot(data, ax, label=label)to support the new version of |
Contributor
|
thanks @bktaha -- I have seen this |
Contributor
Contributor
|
thanks @bktaha I will merge this on Monday in coordination with QuantEcon/lecture-python#231 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the discussion in #519, refactor the method
rank_size_plotininequality.pyso the output now is the data to be plotted instead of a pyplotAxesobject. This is in line with the rest of the methods in this module. The method is renamed torank_sizeto reflect this change.Also added test for the new method, which checks that
xandyarrays are the same length.(c x 100)%of the input, as specified.Edited the
docstringfor the other two methods in the module for pep8 compliance.This closes #519