You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds 0.36.2 as a minimum numba version required for installation in setup.py
numba is one of the key dependencies for QuantEcon.py. Given our user base -- it may be helpful to alternatively write a version check in the base __init__.py file which would give us the opportunity to issue a more useful error message based on conda.
Could check if numba.__version__ > minimum value otherwise print out instructions to upgrade such as conda install numba=0.37. Any comments welcome.
I think adding a minimum version in setup.py (i.e., the current status of the PR) is sufficient (isn't it always the case that the user who updates QE to the version that contains this patch will automatically update Numba to the minimum version, if below it?).
Another issue: should we list all the requirements, including numpy and scipy, in install_requires in setup.py?
isn't it always the case that the user who updates QE to the version that contains this patch will automatically update Numba to the minimum version, if below it?
thanks @oyamad. You're right - that should be true although I haven't tested it.
I guess I was thinking of only minimum dependencies that require version constraints, such as numba where the project uses many of the latest features available. But you're probably right - we should have the full list of dependencies (just without version number if not required).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
0.36.2as a minimum numba version required for installation insetup.pynumbais one of the key dependencies for QuantEcon.py. Given our user base -- it may be helpful to alternatively write a version check in the base__init__.pyfile which would give us the opportunity to issue a more useful error message based onconda.Could check if
numba.__version__ > minimum valueotherwise print out instructions to upgrade such asconda install numba=0.37. Any comments welcome.