Skip to content

Mark OperatorBase::makeClone virtual function const #5804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ye-luo wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Mark OperatorBase::makeClone virtual function const #5804

ye-luo wants to merge 2 commits into from
+88 −89

Conversation

@ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Feb 11, 2026

Proposed changes

makeClone of ParticleSet and TrialWaveFunction are already const.

What type(s) of changes does this code introduce?

  • Refactoring (no functional changes, no api changes)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

laptop

Checklist

    • I have read the pull request guidance and develop docs
    • This PR is up to date with the current state of 'develop'
    • Code added or changed in the PR has been clang-formatted
    • This PR adds tests to cover any new code, or to catch a bug that is being fixed
    • Documentation has been added (if appropriate)

@ye-luo ye-luo marked this pull request as draft February 11, 2026 19:05
@ye-luo ye-luo marked this pull request as ready for review February 13, 2026 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ye-luo