Skip to content

Conversation

@TomKae00
Copy link
Contributor

@TomKae00 TomKae00 commented Nov 19, 2024

Closes # (if applicable).

Changes proposed in this Pull Request

  • Added energy to power ratio calculations for water pit and tank storage
  • Changes allow the integration of these storages into pypsa-eur as storage units.

Checklist

  • [✓] Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • [✓] Data source for new technologies is clearly stated.
  • [✓] Newly introduced dependencies are added to environment.yaml (if applicable).
  • [✓] A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • [✓] I consent to the release of this PR's code under the GPLv3 license.

@amos-schledorn
Copy link
Contributor

Looks great! Just a small suggestion for readability. Also, could you add an entry in the release notes?

@amos-schledorn amos-schledorn self-requested a review November 26, 2024 12:53
Copy link
Contributor

@amos-schledorn amos-schledorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@amos-schledorn amos-schledorn merged commit 8d0c8bf into PyPSA:master Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants