biochar pyrolysis and AEC at small scale #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adjust units in sheets 105. wrong formatting from DEA in investment and energy content
added:
1) biochar pyrolysis
- added in the list of technolgies, excel_sheet to read from DEA and parameters.
- added a new function: "biochar_pyrolysis_harmonise_dea", which retrived data from DEA and applies simple operations to return efficencies and investments on the desidered basis
- modified function "order_data" to add the units corresponding to biochar pyrolysis.
2) electrolysis at small scale (10 MW)
- no changes to functions, it follows the same approach of standard AEC
added biochar pyrolysis (original DEA data only from 2025) and AEC electrolysis at small scale
added biochar pyrolysis (original DEA data only from 2025) and AEC electrolysis at small scale
added biochar pyrolysis (original DEA data only from 2025) and AEC electrolysis at small scale
Contributor
Author
|
This pull request adds pyrolysis for biochar production from the DEA technology catalogue. |
Contributor
Author
|
this pull request adds pyrolysis for biochar production to the technology-data. |
Collaborator
|
thanks @BertoGBG ! |
s8au
reviewed
Nov 27, 2024
|
|
||
| # normalizing costs to biochar output | ||
| df_divid = pd.concat((df.iloc[df.index.str.contains("Biochar Output")], | ||
| df.iloc[df.index.str.contains("Heat Output")]), axis=0).sum(axis=0, skipna=False) |
Contributor
There was a problem hiding this comment.
As far as I understand your code, you change "Heat output" to x % with the df_sum*100 operation in line 892, while Biochar Output is still 0.4. Do you not need to adjust that as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes # (if applicable).
Changes proposed in this Pull Request
Checklist
doc.environment.yaml(if applicable).doc/release_notes.rstof the upcoming release is included.