-
Notifications
You must be signed in to change notification settings - Fork 6
Description
I noticed when playing back certain songs, some instruments sound very out of tune, some more than others (synths especially). I also found that this was already a known issue for a while, but I found the cause.
Every looped sample starts looping one sample too late. This causes the pitch to rise, and for shorter loops, this increase in frequency is greatly exaggerated.
To see if I could fix it, I opened the .sf2 output from audioutil in Polyphone, a soundfont editor. In the attached images you can easily tell that the loop is incorrect, and decrementing the loop beginning point by one fixes it. I have confirmed this by fixing a handful of samples and playing sounds that use them.
This effects all looped samples--there's probably an off-by-one error somewhere.

