Enhance UI elements and improve touch handling#70
Open
Himanth-reddy wants to merge 3 commits intoProdigyV21:mainfrom
Open
Enhance UI elements and improve touch handling#70Himanth-reddy wants to merge 3 commits intoProdigyV21:mainfrom
Himanth-reddy wants to merge 3 commits intoProdigyV21:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request brings several improvements to the app's loading flow and modal dialog handling, as well as visual enhancements to the loading screen and cloud pairing modal. The most significant changes are the introduction of a more robust loading state before app startup, a new reusable modal scrim for dialogs, and visual updates to the loading and modal UI components.
App startup and loading flow:
ArvioLoadingScreen) until all are ready. This prevents premature navigation and ensures the app is fully initialized before user interaction. (MainActivity.kt[1] [2] Ff69cdc6L384R391, [3]Modal dialog improvements:
ModalScrimcomposable that provides a consistent darkened background and dismiss-on-click-outside behavior for modals. This is now used across multiple modal dialogs in the settings screen for a more unified and user-friendly experience. (SettingsScreen.kt[1] [2] [3] [4] [5]SettingsScreen.kt[1] [2] [3] [4]hasBlockingModalflag, simplifying code and ensuring navigation is blocked whenever any modal is open. (SettingsScreen.kt[1] [2]Visual and UI enhancements:
MainActivity.kt[1] [2] [3] [4]SettingsScreen.kt[1] [2]These changes collectively improve the user experience during app startup and when interacting with modal dialogs, while also modernizing the app's visual design.