-
Notifications
You must be signed in to change notification settings - Fork 242
QA Observation Bugfix/FOUR-14155: You cannot filter using "between" from the second page #6227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
gustavobascope
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No observations
|
QA server K8S was successfully deployed https://ci-a3330cff72.engk8s.processmaker.net |
|
Analyzing this change, this behavior should also be appearing in the 'Tasks' listing. Please review the 'page' property in files 'resources/js/requests/components/RequestsListing.vue' and 'resources/js/tasks/components/ListMixin.js'. The correct logic would be:
The function you should analyze is 'resources/js/common/PMColumnFilterPopoverCommonMixin.js -> storeFilterConfiguration()'; this is where the configuration is saved. It is only necessary to consider the 'filters' variable in this function. Please let's consider analyzing alternative solutions that Nolan can provide us with, thank you. |
|
The problem that was detected is that when a filter is used on page 2 or subsequent pages, the result is sent to page 1, but the screen remains on page 2, showing that no results were found. But if you go back to page 1, the filter results are found. |
|
QA server K8S was successfully deployed https://ci-a3330cff72.engk8s.processmaker.net |
nolanpro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CarliPinell I think you need to add previousAdvancedFilter to resources/js/tasks/components/TasksList.vue in the data() method
…s/TasksList.vue in the data() method
|
|
I have added the variable 'previousAdvancedFilter' in file 'resources/js/tasks/components/TasksList.vue', so this would be approved. Thank you. @CarliPinell @nolanpro |
|
QA server K8S was successfully deployed https://ci-a3330cff72.engk8s.processmaker.net |

0.0% Coverage on New Code
0.0% Duplication on New Code
Solution
This ticket fixes issue with filter between in second page in Requests
How to Test
Go to Requests, add between filter in STARTED column
Related Tickets & Packages
https://processmaker.atlassian.net/browse/FOUR-14155
Code Review Checklist
ci:deploy
ci:next