Skip to content

Conversation

@eiresendez
Copy link
Contributor

@eiresendez eiresendez commented Feb 7, 2024

Issue & Reproduction Steps

Previously, when a process was created from a template, the import process incorrectly generated the web entry URL, as it omitted the application URL. This issue was due to the use of getenv('APP_URL') instead of config('app.url').

This PR resolves instances where the web entry URL does not include the application URL.

  1. Have a process with web entry imported or created from a previous version.
  2. Review the link webentryRouteConfig.entryUrl.
  3. For backward compatibilities is important to create a script to correct the entryUrl for all processes.

Solution

  • An upgrade script has been developed to modify the web entry URL for all affected processes, but only when necessary, i.e., when the current web entry URL is not a valid URL.

How to Test

Run the script.
Review in process-catalogue.

Before upgrade:

Screen.Recording.2024-02-07.at.2.38.15.p.m.mov

After upgrade:

Screen.Recording.2024-02-07.at.2.39.49.p.m.mov

Related Tickets & Packages

@eiresendez eiresendez requested a review from pmPaulis February 7, 2024 21:07
@processmaker-sonarqube
Copy link

@pmPaulis
Copy link
Contributor

pmPaulis commented Feb 8, 2024

@eiresendez
it works fine
Screenshot from 2024-02-08 10-55-45

@ryancooley ryancooley merged commit 146c477 into next Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants