-
Notifications
You must be signed in to change notification settings - Fork 242
FOUR-13980 Fix Case title overlaps task name in saved searches #6158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
QA server K8S was successfully deployed https://ci-edce233241.engk8s.processmaker.net |
| break; | ||
| case "case_title": | ||
| field.name = "__slot:case_title"; | ||
| // eslint-disable-next-line no-param-reassign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove commented code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is needed since it is a linter comment to enable add/set the property truncate in the parameter column.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line were removed, and are handled in SavedSearchController
| this.tableHeaders = this.getColumns(); | ||
| this.tableHeaders.forEach((column) => { | ||
| if (column.field === "case_title") { | ||
| // eslint-disable-next-line no-param-reassign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove commented code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line were removed, and are handled in SavedSearchController
gustavobascope
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this could truncate the text
savedsearch package
controller SavedSearchController.php
adjustColumns method
case 'case_title':
$this->adjustCommonColumns($column, 200, 'case_title', null, 'true', 'true');
break;
| for (const task of value) { | ||
| htmlString += ` | ||
| <div> | ||
| <div class="text-truncate"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could add this case on the savedsearch package
controller SavedSearchController.php
adjustColumns method
case 'case_title':
$this->adjustCommonColumns($column, 200, 'case_title', null, 'true', 'true');
break;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing thanks for the suggestion I added the code to the SavedSearchController PR #410.
But this change is needed, when a request has two or more active tasks the active_tasks column it will show two or more lines, like the following:
As you could see in the previous image, the ellipsis does not appear becasue of the use of <div> to render multiple lines of tasks.
This line of code adds a text-trucate to each active task div of the request to add the ellipsis like:
julceslauhub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
|
QA server K8S was successfully deployed https://ci-edce233241.engk8s.processmaker.net |
|
|
QA server K8S was successfully deployed https://ci-edce233241.engk8s.processmaker.net |




0.0% Duplication on New Code
Issue & Reproduction Steps
The content of the case title column is stepping on the task name column in a save search
Solution
How to Test
Related Tickets & Packages
Code Review Checklist
ci:next
ci:deploy