Skip to content

Conversation

@runyan-co
Copy link
Contributor

@runyan-co runyan-co commented Dec 21, 2023

Issue

The status column in the users table is sometimes registered as an enum() when is should be a varchar. This PR converts that column to varchar if it finds it that way.

Reproduction Steps

  1. Log in with admin user
  2. Create a user
  3. Go to profile of new user
  4. Go to admin tab
  5. Search new user and edit

First scenario:

  1. Go to Settings
  2. Select Out of Office in Status list
  3. Click on Save button
  4. Reload page

Second scenario:

  1. Go to Settings
  2. Select Scheduled in Status list
  3. Click on Save button
  4. Reload page

Solution

  • Add a database migration to convert the status column to varchar

How to Test

The reproduction steps should not reproduce the issue.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@processmaker-sonarqube
Copy link

@boliviacoca boliviacoca requested a review from caleeli December 21, 2023 19:52
@ryancooley ryancooley merged commit 5d488c5 into develop Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants