-
Notifications
You must be signed in to change notification settings - Fork 242
FOUR-12245 customize SAML library used for the idp #5767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
QA server was successfully deployed https://ci-e142f18c80.eng.processmaker.net |
| @@ -0,0 +1,21 @@ | |||
| @php echo '<?xml version="1.0"?>' @endphp | |||
| <md:EntityDescriptor xmlns:md="urn:oasis:names:tc:SAML:2.0:metadata" validUntil="2027-01-20T19:04:25Z" cacheDuration="PT1485371065S" entityID="{{ url(config('samlidp.issuer_uri')) }}"> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Questions: What are the "validUntil" and "cacheDuration" values based on when they are generated? Can't current "hardcoded" values be generated in the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These variables mean
validUntilthe expiration time of the metadatacacheDurationthe maximum period of time a consumer should cache the metadata
I added some functions to generate them dynamically
|
SonarQube Quality Gate |
|
QA server was successfully deployed https://ci-e142f18c80.eng.processmaker.net |
julceslauhub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved








Solution
Related Tickets & Packages
FOUR-12245
Code Review Checklist
ci:deploy
ci:next
ci:SAML_SP_DESTINATION=https://keycloak.processmaker.net/realms/pm4-next/broker/pm4-saml/endpoint