-
Notifications
You must be signed in to change notification settings - Fork 55
(MAINT) Rename build scripts #1285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(MAINT) Rename build scripts #1285
Conversation
8ed3592 to
bc7bd0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR renames the build scripts to reflect their intended use after months of transition to the new build system. The key changes consolidate build.new.ps1 as the default build.ps1 script, preserve the legacy script as packaging.ps1 for packaging releases, and remove the obsolete comparison script.
Key Changes
- Renamed
build.ps1topackaging.ps1to reflect its continued use for creating release packages (includingrpmanddebformats) - Renamed
build.new.ps1tobuild.ps1as the default build script for local development and CI - Removed
build.comparison.ps1as it's no longer needed - Updated all references across documentation, CI pipelines, VS Code tasks, and configuration files
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packaging.ps1 | New file containing legacy build script, retains all package types including rpm/deb for releases |
| build.ps1 | Updated to be the default build script (formerly build.new.ps1), supports common package types for development |
| build.new.ps1 | Deleted - consolidated into build.ps1 |
| build.comparison.ps1 | Deleted - no longer needed |
| CONTRIBUTING.md | Updated build script references from build.new.ps1 to build.ps1 |
| .github/instructions/instructions.md | Updated all build script references and added note about legacy packaging.ps1 |
| .vscode/tasks.json | Updated task commands to use build.ps1 |
| .vscode/schemas/definitions.json | Updated schema description to reference build.ps1 |
| .pipelines/DSC-Windows.yml | Updated to use packaging.ps1 for building and creating release packages |
| .pipelines/DSC-Official.yml | Updated to use packaging.ps1 for package version retrieval and package creation |
| .github/workflows/rust.yml | Updated all workflow steps to use build.ps1 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
c139a2e to
9eb0695
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
5425076 to
575b7f3
Compare
This change renames the legacy build script from `build.ps1` to `packaging.ps1` to reflect that its continued use is only for the packaging steps. It updates references to and invocations of the script but makes no changes to any functionality.
This change removes the comparison script for the build scripts. It is no longer needed.
This change renames the build script and updates all references to it in configuration, CI automation, and maintainer documentation.
575b7f3 to
195d645
Compare
PR Summary
This change:
build.ps1topackaging.ps1to reflect its continued use in packaging releases.build.new.ps1tobuild.ps1as the default build script.build.comparison.ps1script as it's no longer needed.build.new.ps1in project configuration, CI automation, and maintainer documentation.PR Context
This change renames the build scripts. Previously, we had both
build.ps1andbuild.new.ps1. It's been a few months since we transitioned to the new build script, which has been functional for our CI and local development.For now, we're keeping the legacy script as
packaging.ps1until we confirm that the new build script is equally functional for packaging a release.