Add new prometheus metrics for replications queues and set those instead of logging queue errors #464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the send and/or recv replication queues are full, previous behaviour was to log an error message. Given that replication messages can be in the order of thousands or tens of thousands per second, this would cause a doom loop of performance problems.
Instead, this PR creates new metrics to track the send queue size and also to track when the queue size is exceeded. These metrics are used instead of logging.
New metrics examples: