Skip to content

bug fix: support Windows Docker paths, Gemini model defaults, and session stability#35

Merged
PleasePrompto merged 3 commits intoPleasePrompto:mainfrom
liuh886:main
Mar 8, 2026
Merged

bug fix: support Windows Docker paths, Gemini model defaults, and session stability#35
PleasePrompto merged 3 commits intoPleasePrompto:mainfrom
liuh886:main

Conversation

@liuh886
Copy link
Copy Markdown
Contributor

@liuh886 liuh886 commented Mar 7, 2026

This PR fixes several critical issues encountered when running ductor on Windows with Docker sandboxing and improves the Gemini user experience.

  1. Fix Gemini Model List: Added DEFAULT_GEMINI_MODELS as a fallback. Previously, if dynamic discovery failed, the model list would remain empty, preventing users from selecting models (including auto). [Bug]: Gemini model list is wiped and remains empty if dynamic discovery fails #34
  2. Windows Docker Compatibility: (Referencing commit d9063a4) Fixed pathing issues where Windows-style backslashes were being passed to Docker's chdir, causing sub-agent startup failures. [Bug]: Windows Docker + Gemini runtime issues in dev build #33
  3. Session Stability: (Referencing commit 0aac267) Fixed an issue where specific trigger words like @Botfather could cause session errors. [Bug]: Session error - Failed to start Gemini Cli due to "@BotFather" in agent_tools #32

Testing Done

  • Verified that /model now correctly shows Gemini models even when dynamic discovery is unavailable.
  • Verified sub-agents start correctly in Docker on a Windows host.
  • Verified that existing sessions are correctly resolved.

@PleasePrompto PleasePrompto merged commit 73244cc into PleasePrompto:main Mar 8, 2026
@PleasePrompto
Copy link
Copy Markdown
Owner

Hey @liuh886, thanks a lot for this PR! Really appreciate you taking the time to dig into these issues and put together fixes.

I can't easily test Windows + Docker + Gemini setups myself, so having someone actually hitting these bugs in the wild and reporting them with concrete details is super valuable.

I've merged your PR and then layered our own fixes on top. Here's what we extended:

Thanks again for the contribution — keep the bug reports coming!

PleasePrompto added a commit that referenced this pull request Mar 8, 2026
Remove redundant DEFAULT_GEMINI_MODELS from config.py (fallback is
handled by _FALLBACK_GEMINI_MODELS in gemini_cache.py). Fix lint
violations in PR #35 test code.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants