Skip to content

Svg maps node naming standardization#61

Open
Totoro51212 wants to merge 5 commits intomainfrom
SVG-maps-node-naming-standardization
Open

Svg maps node naming standardization#61
Totoro51212 wants to merge 5 commits intomainfrom
SVG-maps-node-naming-standardization

Conversation

@Totoro51212
Copy link
Contributor

  • Standardized node naming for the following svg files
  • ISTfloor1.svg
  • ISTfloor2.svg
  • istF1.svg
  • istF2.svg

- completed renaming nodes of IST f1 svgs to standard.
- began replacing node names of IST f2 svg file
- changed node names to reflect new naming scheme for ISTfloor2.svg and istF2.svg
@Totoro51212 Totoro51212 requested review from a team as code owners February 19, 2026 15:28
Copy link
Member

@DJFreer92 DJFreer92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the new names look good, but there are several that still need some tweaking.

  1. Entrances, exits, elevators, vending machines, water fountains, and stairs should have the full spelling of their cardinal direction, instead of just the first letter, and should have a #. For example, "ist_entrance_n_f1" should be "ist_entrance_north_1_f1".
  2. The center hallway node isn't following the hallway naming convention.
  3. Mosaic should be "ist_mosaicCafe_south_1_f1".
  4. The letter following the direction in the hallway nodes should indicate with hallway it is starting from 'a' and not what it's cardinal position is. For example "ist_hall_n-s_s_1_f1" should be either "ist_hall_n-s_a_1_f1" or "ist_hall_n-s_b_1_f1". I think the lettering system for the hallways should start with 'a' for the e-w hallway closest to the main entrance, and continue through the alphabet as you get further away. Similarly I think it should start with 'a' for the n-s hallway furthest to the right when entering the building through the main entrance, and continue through the alphabet as you get further away. And I think the same standard can be applied for numbering the nodes going down a hallway. This standard would be easy to apply to any building.
  5. Vending machines should be "vending" not "vendingMachines", water fountains should be "fountain" not "waterFountains". For example, "ist_vendingMachines_f1" should be "ist_vending_south_1_f1" and "ist_waterFountains_f1" should be "ist_fountain_south_1_f1".
  6. Are nodes "ist_north_center_f2", "ist_center_n_f2", etc. hallways? If so, they need to follow the hallway naming convention.
  7. There is a node "ist_entrance_n_f2", but there are no entrances on the 2nd floor, only exits.
  8. There should be nodes for the inside stairs on both the 1st and 2nd floors.
  9. Rename "ist_library_n_f2" to "ist_commons_north_1_f2".
  10. "is_stair_nw_f2" misspelled "ist".
  11. Stair nodes should be "stairs" instead of "stair".

I know a lot of this seems pedantic and redundant, but it'll be difficult for the script extracting the coordinates from the SVGs to parse labels that are inconsistent between the SVGs and the metadata. So we have to have a very strict naming convention that both follow precisely. Plus it also helps with human readability which is nice since we have to do all of this by hand.

@DJFreer92 DJFreer92 requested a review from a team February 20, 2026 03:39
@Totoro51212
Copy link
Contributor Author

Thanks for doing a thorough review, I will get to the changes soon

Totoro51212 and others added 2 commits March 3, 2026 14:15
- Added more nodes for IST f1 center hallway from n-s for better accuracy
- Added missing fountain on IST f1
- corrected IST f1 and f2 node naming to reflect naming scheme:
-- fixed hallway naming
-- fixed entrance and specialty node naming
-- fixed completely incorrect named nodes
@Totoro51212 Totoro51212 enabled auto-merge (squash) March 6, 2026 23:17
@Totoro51212
Copy link
Contributor Author

Revised, please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants