Open
Conversation
Contributor
Totoro51212
commented
Feb 19, 2026
- Standardized node naming for the following svg files
- ISTfloor1.svg
- ISTfloor2.svg
- istF1.svg
- istF2.svg
- completed renaming nodes of IST f1 svgs to standard. - began replacing node names of IST f2 svg file
- changed node names to reflect new naming scheme for ISTfloor2.svg and istF2.svg
DJFreer92
requested changes
Feb 20, 2026
Member
There was a problem hiding this comment.
Most of the new names look good, but there are several that still need some tweaking.
- Entrances, exits, elevators, vending machines, water fountains, and stairs should have the full spelling of their cardinal direction, instead of just the first letter, and should have a #. For example, "ist_entrance_n_f1" should be "ist_entrance_north_1_f1".
- The center hallway node isn't following the hallway naming convention.
- Mosaic should be "ist_mosaicCafe_south_1_f1".
- The letter following the direction in the hallway nodes should indicate with hallway it is starting from 'a' and not what it's cardinal position is. For example "ist_hall_n-s_s_1_f1" should be either "ist_hall_n-s_a_1_f1" or "ist_hall_n-s_b_1_f1". I think the lettering system for the hallways should start with 'a' for the e-w hallway closest to the main entrance, and continue through the alphabet as you get further away. Similarly I think it should start with 'a' for the n-s hallway furthest to the right when entering the building through the main entrance, and continue through the alphabet as you get further away. And I think the same standard can be applied for numbering the nodes going down a hallway. This standard would be easy to apply to any building.
- Vending machines should be "vending" not "vendingMachines", water fountains should be "fountain" not "waterFountains". For example, "ist_vendingMachines_f1" should be "ist_vending_south_1_f1" and "ist_waterFountains_f1" should be "ist_fountain_south_1_f1".
- Are nodes "ist_north_center_f2", "ist_center_n_f2", etc. hallways? If so, they need to follow the hallway naming convention.
- There is a node "ist_entrance_n_f2", but there are no entrances on the 2nd floor, only exits.
- There should be nodes for the inside stairs on both the 1st and 2nd floors.
- Rename "ist_library_n_f2" to "ist_commons_north_1_f2".
- "is_stair_nw_f2" misspelled "ist".
- Stair nodes should be "stairs" instead of "stair".
I know a lot of this seems pedantic and redundant, but it'll be difficult for the script extracting the coordinates from the SVGs to parse labels that are inconsistent between the SVGs and the metadata. So we have to have a very strict naming convention that both follow precisely. Plus it also helps with human readability which is nice since we have to do all of this by hand.
Contributor
Author
|
Thanks for doing a thorough review, I will get to the changes soon |
- Added more nodes for IST f1 center hallway from n-s for better accuracy - Added missing fountain on IST f1 - corrected IST f1 and f2 node naming to reflect naming scheme: -- fixed hallway naming -- fixed entrance and specialty node naming -- fixed completely incorrect named nodes
Contributor
Author
|
Revised, please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.