Closed
Conversation
Mistake fixed
The default text size in ComponentBase was defined as 10 pixels instead of 10dp, which causes tiny text and does not reflect the javadoc and the general behavior of setTextSize(...)
ISSUE:
When using multiple LineDataSets like the follows:
int solidColor = 0xFFFF00FF;
dataSet.setColor(solidColor);
dataSet.setCircleColor(solidColor);
int semiTransparentColor = 0x8A000000;
fadedSet.setColor(semiTransparentColor);
LineData data = new LineData(dataSet, fadedSet);
the circles in 'dataSet' will rendered with the alpha from
fadedSet (0x8A).
The reason for this is that mRenderPaint is not reset properly
before drawing the circles. The first time drawCircles is called
the imageCache.fill(...) method is used where the color is set by
mRenderPaint.setColor(set.getCircleColor(i)), restoring the alpha
to 0xFF. The second time homever, imageCache.fill(...) is not called
which means that mRenderPaint will use it's old color/alpha,
which in this case is from fadedSet.
TEST INFO:
To trigger the issue, add the following to LineChartActivity1:
final ArrayList<Entry> fadedEntries = new ArrayList<>();
for (int i = 0; i < count; i++) {
float val = (float) (Math.random() * range) + 3;
fadedEntries.add(new Entry(i, val));
}
final LineDataSet fadedDateSet = new LineDataSet(fadedEntries, "Faded");
fadedDateSet.setColor(0x42000000);
dataSets.add(fadedDateSet); // add the datasets
and launch the first item in the example app.
SOLUTION:
This commit replaces mRenderPaint with null when drawing the circle
bitmap. If circleColor has been defined with a semi-transparent
color, it will be drawn that way in the cached bitmap, hence the the
bitmap itself does not need to be drawn with an alpha.
Entry cons in all chart types
Set javadoc character encoding to utf8
fix tests for java executable location in gradlew to be compatible with bash 4.3.42
Fix for default text size being set in PX instead of DP
Fix circles inherit alpha PhilJay#2620
Fixed docs typo in AxisBase.java
Fix: typo for October
andrebstv
approved these changes
Feb 26, 2017
andrebstv
left a comment
andrebstv
left a comment
There was a problem hiding this comment.
Could use some comments but overall ok.
Great feature.
This was referenced Apr 22, 2017
|
I think this pull request has a bug since does not support right YAxis. |
|
I want this commit in 3.0.3 !!! :) and yes, hermamitr, is right. Commit not drawing right axis title: and i found 1 bug: whel legend on bottom and write mChart.getXAxis().setTitle("test!"); then xAxis title and legend at the same place :( |
Author
|
I trashed this PR so I had to create a new one with the same changes: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'am using this myself on a LineChart and it's working well.
MPAndroidChart is the best chart library for Android but it's useless for me without axis titles and I think it's the most requested feature.
Related feature requests:
#2034
#1869
#716
#828
#1324
#1440
#513
Screenshot