Skip to content

Conversation

@tiku-paystack
Copy link
Contributor

Description

This Dockerfile pulls a magento2 docker image and sets it up

Motivation and Context

The Dockerfile would be used to startup an ECS container with magento2 and the paystack magento2 plugin running on it.

How Has This Been Tested?

The Dockerfile has been tested locally using docker-compose and used to run an ECS task.
Link to the deployed magento2 environment- https://plugin-alb-1949830085.eu-west-2.elb.amazonaws.com/

Acceptance Criteria

  • The resulting ECS container should have the magento2 and Paystack magento2 plugin installed.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful. (Please rebase, removing useless commits if not)
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • My change requires change(s) to the environment.
  • My change requires change(s) to the database.
  • Other information.

@tiku-paystack tiku-paystack force-pushed the task/INFRA-279-create-dockerfile branch from 1a9db3b to 36232dd Compare April 6, 2020 18:46
Copy link

@gbade-paystack gbade-paystack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kindly edit the readme with how to run the plugin locally with Docker.

Copy link

@gbade-paystack gbade-paystack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you give this magento image - https://hub.docker.com/r/bitnami/magento - a try before settling on the alexcheng one - https://hub.docker.com/r/alexcheng/magento2?

During our sync, I expressed why we had a preference for official images as against images from Dockerhub community users. The most important ones I stated were security and support in the form of updates and security fixes. The image that you are using here - alexcheng/magento2 - has not been updated for a year according to its' page on Dockerhub. So, how do we ensure that the image doesn't have any security holes or out-of-date software, and going forward, how do we get security fixes and updates for this image? Also, when we want to update, say to a new version of magento or update the Linux os underneath, how do we go about it?

@tiku-paystack tiku-paystack force-pushed the task/INFRA-279-create-dockerfile branch from 36232dd to e68df52 Compare April 8, 2020 19:44
@tiku-paystack tiku-paystack force-pushed the task/INFRA-279-create-dockerfile branch from e68df52 to d3b4459 Compare April 8, 2020 19:56
@tiku-paystack tiku-paystack merged commit cbb291b into master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants