Conversation
- Always use status enums declared in Document model - Update status getters and setters: carousel, export and document API
maxkfranz
left a comment
There was a problem hiding this comment.
Looks good. Two comments:
(1) Are you planning on converting all the existing documents manually with the new status? Or should this be handled with an automatic conversion in the code?
(2) The naming of isPublic() is a bit inconsistent with the other status methods. I suppose public() and publicize() would line up with your other methods, but this isn't very important.
At this point I can migrate this easily with such a simple change. My approach has been to do it 'offline' (local) then load it into an updated instance
Yeah I just went with the most unambiguous. Didn't feel like |
maxkfranz
left a comment
There was a problem hiding this comment.
Fair enough. Let's just merge it in
|
I'm gonna clear out the db at some point ... |
INITIATEDSUBMITTEDPUBLICTRASHEDRefs #843